Darren Hart wrote on 2011-08-03: > On 08/02/2011 04:43 AM, Richard Purdie wrote: >> On Tue, 2011-08-02 at 14:08 +0800, Dexuan Cui wrote: >>> [YOCTO #671] >> > For a patch to address a relatively benign bug I thought the standard > procedure would be for it to await feedback for more than 5 hours. I I agree. :-)
> was hoping to have an opportunity to review this fix as I was working > with the team in root causing the bug. > > + if [ -z "$BDIR" ]; then > + if expr "$1" : '.*/$' >/dev/null; then echo >&2 "Error: please > + remove any trailing / in the argument." > > This portion of the patch is really not necessary. There is no > meaningful difference between the path with or without the trailing > slash, a much simpler and less noisy solution would be to simply strip > the trailing slash from the user input before doing the rest of the input > validation. Hi Darren, thanks for the suggestion! I considered the idea too, however, if we use the idea, it looks not that simple to gracefully and concisely handle the case if a user (by accident or by prank) passes / as $1 here, i.e., "readlink -f" would fail. So I didn't do that. Thanks, -- Dexuan _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
