On 8/10/17 6:56 PM, Martin Jansa wrote: > On Thu, Aug 10, 2017 at 03:34:48PM -0500, Mark Hatle wrote: >> On 8/10/17 3:18 PM, Martin Jansa wrote: >>> -2 >> >> I agree that autoconf-archive should be in oe-core. But... > > No argument about that, it was already merged to oe-core, I was only > commenting about the gnome-common change included in this commit.
Sorry, I missed the context.. ya if the gnome change is arch or board specific that is wrong. There should be no reason for that. --Mark >> >>> LBTM >>> >>> >>> If gnome-common should depend on TUNE_PKGARCH autoconf-archive, then it >>> cannot inherit allarch anymore, see: >>> >>> >>> ERROR: gnome-common different signature for task >>> do_package_write_ipk.sigdata between qemux86copy and qemuarm >>> runtaskdeps changed: >>> autoconf-archive/autoconf-archive_2016.09.16.bb.do_packagedata with hash >>> e26a8076711b7e88a3ffcda74a9e5332 >>> changed to >>> autoconf-archive/autoconf-archive_2016.09.16.bb.do_packagedata with hash >>> ee3f5138593bed3feb8519cf3c26aa7b >>> Hash for dependent task >>> autoconf-archive/autoconf-archive_2016.09.16.bb.do_packagedata changed from >>> e26a8076711b7e88a3ffcda74a9e5332 to ee3f5138593bed3feb8519cf3c26aa7b >>> >> >> There should not be an architectural difference. There is no reason it >> shouldn't be allarch. Part of the reason we really need to move it into >> oe-core >> is that currently different BSPs may implement it differently making the >> 'allarch' even MORE complicated. > > I don't understand what you mean with BSPs wrt autoconf-archive, but as > it is now, the autoconf-archive in oe-core isn't allarch, so allarch > gnome-common in meta-oe cannot depend on it. > > It could be whitelisted in layer.conf or allarch can be dropped from > gnome-common or autoconf-archive can be updated to inherit allarch as > well - either of these options is fine with me, but I won't merge this > change in current state. > >> >> --Mark >> >>> >>> On Fri, Jul 28, 2017 at 6:45 PM, Khem Raj <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> On Fri, Jul 28, 2017 at 7:01 AM, Patrick Ohly <[email protected] >>> <mailto:[email protected]>> wrote: >>> > Having common macros in OE-core that are needed by autotools based >>> > projects makes sense. For example, tpm2.0-tools in meta-measured >>> > depended on meta-oe only because of autoconf-archive. >>> > >>> > This is a verbatim copy of the autoconf-archive recipe in >>> > meta-openembedded rev 1cbd1bc1, with just one change: the patch which >>> > disabled the installation of ax_code_coverage.m4 and >>> > ax_check_enable_debug.m4 was removed. >>> > >>> > So now autoconf-archive in OE-core provides them. gnome-common in >>> > meta-oe will be changed to not install them and instead depend on >>> > autoconf-archive. >>> >>> +1 >>> LGTM >>> >>> > >>> > Signed-off-by: Patrick Ohly <[email protected] >>> <mailto:[email protected]>> >>> > --- >>> > meta/recipes-devtools/autoconf-archive/autoconf-archive.inc >>> | >>> 15 +++++++++++++++ >>> > meta/recipes-devtools/autoconf-archive/autoconf-archive_2016.09.16.bb >>> <http://autoconf-archive_2016.09.16.bb> | 13 +++++++++++++ >>> > 2 files changed, 28 insertions(+) >>> > create mode 100644 >>> meta/recipes-devtools/autoconf-archive/autoconf-archive.inc >>> > create mode 100644 >>> meta/recipes-devtools/autoconf-archive/autoconf-archive_2016.09.16.bb >>> <http://autoconf-archive_2016.09.16.bb> >>> > >>> > diff --git >>> a/meta/recipes-devtools/autoconf-archive/autoconf-archive.inc >>> b/meta/recipes-devtools/autoconf-archive/autoconf-archive.inc >>> > new file mode 100644 >>> > index 0000000..9684d1f >>> > --- /dev/null >>> > +++ b/meta/recipes-devtools/autoconf-archive/autoconf-archive.inc >>> > @@ -0,0 +1,15 @@ >>> > +LICENSE = "GPLv3" >>> > +HOMEPAGE = "http://www.gnu.org/software/autoconf-archive/ >>> <http://www.gnu.org/software/autoconf-archive/>" >>> > +SECTION = "devel" >>> > + >>> > +DEPENDS += "m4-native" >>> > +DEPENDS_class-native = "m4-native gnu-config-native" >>> > +DEPENDS_class-nativesdk = "m4-nativesdk gnu-config-nativesdk" >>> > + >>> > +RDEPENDS_${PN} = "m4 gnu-config gnome-common" >>> > +RDEPENDS_${PN}_class-native = "m4-native gnu-config-native" >>> > +RDEPENDS_${PN}_class-nativesdk = "m4-nativesdk gnu-config-nativesdk" >>> > + >>> > +SRC_URI = "${GNU_MIRROR}/${BPN}/${BPN}-${PV}.tar.xz" >>> > + >>> > +inherit autotools >>> > diff --git >>> a/meta/recipes-devtools/autoconf-archive/autoconf-archive_2016.09.16.bb >>> <http://autoconf-archive_2016.09.16.bb> >>> b/meta/recipes-devtools/autoconf-archive/autoconf-archive_2016.09.16.bb >>> <http://autoconf-archive_2016.09.16.bb> >>> > new file mode 100644 >>> > index 0000000..0a1a771 >>> > --- /dev/null >>> > +++ >>> b/meta/recipes-devtools/autoconf-archive/autoconf-archive_2016.09.16.bb >>> <http://autoconf-archive_2016.09.16.bb> >>> > @@ -0,0 +1,13 @@ >>> > +require autoconf-archive.inc >>> > + >>> > + >>> > +PARALLEL_MAKE = "" >>> > + >>> > +LICENSE = "GPLv2 & GPLv3" >>> > +LIC_FILES_CHKSUM = >>> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" >>> > + >>> > +SRC_URI[md5sum] = "bf19d4cddce260b3c3e1d51d42509071" >>> > +SRC_URI[sha256sum] = >>> "e8f2efd235f842bad2f6938bf4a72240a5e5fcd248e8444335e63beb60fabd82" >>> > + >>> > +EXTRA_OECONF += "ac_cv_path_M4=m4" >>> > +BBCLASSEXTEND = "native nativesdk" >>> > >>> > base-commit: d3a41fbd94462efc8c6f1b55f6fb54001b447c45 >>> > -- >>> > git-series 0.9.1 >>> > -- >>> > _______________________________________________ >>> > Openembedded-core mailing list >>> > [email protected] >>> <mailto:[email protected]> >>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> [email protected] >>> <mailto:[email protected]> >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core> >>> >>> >>> >>> >> >
signature.asc
Description: OpenPGP digital signature
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
