-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello Paul,
Am 24.08.2017 um 22:53 schrieb Paul Eggleton: > On Friday, 25 August 2017 6:19:46 AM NZST Olaf Mandel wrote: >> For URLs with the npm:// transport but with no other slash in it, >> the common MIRRORS and PREMIRRORS pattern of npm://.*/.* fails to >> match. Add a new pattern in the mirros.bbclass and >> own-mirrors.bbclass classes for these URLs. - -Snipp- > > Couldn't we just do away with npm://.*/.* ? > While that would fix my specific problem, it would introduce a backwards-breaking change: if someone _did_ have a SRC_URI with a slash in it, this would change where on the mirror the package is searched for: SRC_URI = npm://foo.tld/bar;name=baz;version=0.1.2 npm://.*/.* => baz-0.1.2.tar.xz npm://.* => bar/baz-0.1.2.tar.xz So keeping both lines is the better solution. But while testing this I found that the order I chose (first npm://.*, then npm://.*/.*) is wrong: this first tries the changed (wrong) location on the mirror and only then the original (correct) one. It is much more efficient to sort the lines the other way around: this prevents extra network traffic, if the mirror is not local. I will send an updated batch soon. Best regards, Olaf - -- Olaf Mandel -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJZn+/7AAoJEFS9nbRiUh3/0EMIAJTUoXVsvSLWDUm8phbAEoXb jQZW7hfP+CHzn1V7X6kTu4CZlQWhxOzYbv07sd2cz/4+Hr2U/7JJCul2QTQGizc/ NxVKaixR8V0tM0irn8NeAHexLXLj+dKdmbvaG/H/BeHhFZc4eQOt6gmbGZ1F7V2g njcP7nui13HbYpHViGFKMT5hnU9B2gKWQ0FAtY6kGZFS1UDvyGFXyHXn1kU0hzjl 6nRuG0q18uueUEEFxqjo4Cb5BTNEjC/QIGIKbSTsqBIU1r3t7uaPSHIYihnRGZ9M bCpoFKB2PFgi8qFl+cUaFBmtGMeh+loEIDIi1eZ1HmRO7ST0glDmxB0SKM1N06I= =QS0a -----END PGP SIGNATURE----- -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
