Hello Richard, On Tue, Sep 12, 2017 at 5:34 AM, Richard Purdie <[email protected]> wrote: > On Mon, 2017-09-11 at 18:18 -0300, Otavio Salvador wrote: >> The Device Tree is commonly used but it is still kept as a .inc file >> instead of a proper class. Instead now we move the Device Tree code >> to >> a kernel-devicetree class and automatically enable it when the >> KERNEL_DEVICETREE variable is set. >> >> While converting to the class, we reworked the compile and install in >> tasks as well as run the build of the Device Tree files in parallel, >> if possible. >> >> To avoid breakage in existing layers, we kept a linux-dtb.inc file >> which raises a warning telling the user about the change so in next >> release this can be removed. > > Sorry but this patchset doesn't appear to be well tested and has big > issues. For example: > > https://autobuilder.yocto.io/builders/nightly-x86/builds/497/steps/Buil > dImages/logs/stdio > > I'm going to guess that do_compile_devicetree is racing > against do_compile_kernelmodules. Debugging these kinds of races is > tremendously hard and taking a patchset on a key component like the > kernel at this point in M4 where this hasn't been considered is > worrying/risky. > > https://autobuilder.yocto.io/builders/nightly-mips-lsb/builds/461/steps > /BuildImages/logs/stdio > > another form of the same race? The autobuilder is full of these > failures :(
Ok. > I think if this patchset is to go anywhere it needs to be split into > more incremental changes, one to move to the new file structure but not > change the functionality, another looking at parallelisation etc. as > the current approach of "this patch does X + Y + Z" makes review harder > and makes it harder to merge any piece of it. I will do; I will split to the patchset so we have a more granular change. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
