On Wed, Sep 27, 2017 at 10:14:51PM +0000, Khem Raj wrote: > On Wed, Sep 27, 2017 at 2:52 PM Tom Rini <[email protected]> wrote: > > > On Wed, Sep 27, 2017 at 02:01:43PM -0700, Khem Raj wrote: > > > On Wed, Sep 27, 2017 at 10:00 AM, Tom Rini <[email protected]> wrote: > > > > With RSS we need to ensure that when making a bmap image that the > > > > python3 that we created is found via /usr/bin/env rather than the host > > > > python3. Otherwise we're relying on the build host to have bmaptool > > > > support installed. > > Who is staging python3 native here may be that's where it could be added
What do you mean? Adding whatever.bmap to IMAGE_FSTYPES is valid and how you get the bmap file for the whatever image type. bmap-tool-native is correctly inherit'ing python3native which is why it's staged correctly. It's just that images aren't adding the EXTRANATIVEPATH that's required because nothing is telling them that bmap requires it. > > > > > > > > > > > Signed-off-by: Tom Rini <[email protected]> > > > > --- > > > > I played around with a few ways to try and fix this problem, and this > > > > was the best I could come up with. Once this is in we need this in > > pyro > > > > as well as it's broken there too. > > > > --- > > > > meta/classes/image_types.bbclass | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/meta/classes/image_types.bbclass > > b/meta/classes/image_types.bbclass > > > > index 61dca626311e..3ff960e3a889 100644 > > > > --- a/meta/classes/image_types.bbclass > > > > +++ b/meta/classes/image_types.bbclass > > > > @@ -311,3 +311,6 @@ DEPLOYABLE_IMAGE_TYPES ?= "hddimg iso" > > > > # The IMAGE_TYPES_MASKED variable will be used to mask out from the > > IMAGE_FSTYPES, > > > > # images that will not be built at do_rootfs time: vmdk, vdi, qcow2, > > hdddirect, hddimg, iso, etc. > > > > IMAGE_TYPES_MASKED ?= "" > > > > + > > > > +# bmap requires python3 to be in the PATH > > > > +EXTRANATIVEPATH += "${@'python3-native' if > > d.getVar('IMAGE_FSTYPES').find('bmap') else ''}" > > > > -- > > > > > > I think somewhere inherit python3native should fix it. > > > > Yes, image_types.bbclass could also inherit python3native but that > > seemed heavy-handed. There's not some other place that should be doing > > it as the problem is saying we want to call bmaptool, and that's handled > > here. > > > > -- > > Tom > > -- Tom
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
