On 10/10/2017 05:38 AM, Øystein Walle wrote:
> On 10 October 2017 at 14:31, Maciej Borzęcki <[email protected]> 
> wrote:
>> On Tue, Oct 10, 2017 at 2:25 PM, Alexander Kanavin
>>
>>> Where is the typo and what is it, exactly?
>>
>> -set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>>
>> missing _ between CMAKE and ASM
> 
> Correct. As it is the code defines a variable named "CMAKE" with the
> contents "ASM_FLAGS ${CMAKE_C_FLAGS}". As far as CMake is concerned that
> is valid and so this will not generate any form of error, but may
> result in incorrect flags.
> 
> I can resend the patch with a better commit message if you like.

That would be nice. I stared at the line for a bit trying to see the
typo also.

Philip


> 
> --
> Øsse
> 
-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to