On 10/17/2017 05:07 PM, Leonardo Sandoval wrote:

I like the idea of a simpler script to do this job.

Just one minor comment on the code: I would use non-zero exit values in case of errors

Yep, fixed and will resent.

and as a possible future enhancement, use a template (jinja2 for example) to format the email and just populate this with the data from checkpkg.

Current version of the script relies entirely on python3's standard
library; I wouldn't like to introduce 3rd party dependencies. Standard
string formatting is fine for the job imo, although I stretched the
readability to the limit :)

AUH is the system that send emails with upgrade statistics (basically
the system tries to upgrade and prepare the patch if possible) and
RRS is the system that sends emails reporting upgradable recipes
(just those recipes that needs to upgrade). I know, a bit confusing
but in your context you are referring to the RRS.
Actually, the point of the script is that it sends *personal* reminders - RRS wasn't doing that, and I'm not sure how much attention anyone paid to those summaries that RRS sent to yocto ML. So it's a replacement for both perhaps, except it doesn't have the ambition to also do the update work for the maintainer, but 'devtool upgrade && devtool finish' is arguably not more difficult than xsel|git am, followed by author reset :)

Alex
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to