Re: [OE-core] ✗ patchtest: failure for linux-firmware: Bump to bf04291 revision

Leonardo Sandoval Mon, 30 Oct 2017 14:49:47 -0700

On Sun, Oct 29, 2017 at 10:47 AM, Denys Dmytriyenko <[email protected]>wrote:

On Thu, Oct 26, 2017 at 12:51:27PM -0500, Leonardo Sandoval wrote:

 I believe the patchtest complain is valid, some brief explanation
 should be given.


FWIW, it was mentioned in the commit log:

 bf04291 WHENCE: Add new qed firmware
 d8fc990 WHENCE: Add new radeon firmware


Maybe the script needs to be smarter?


Right, we need to improve this.

The current logic is quite simple: if LIC_FILES_CHECKSUM changes, thenlook for something related to it through the following regex

licmark = re.compile('%s|%s|CHECKSUM|CHKSUM' % (metadata,license), re.IGNORECASE)


where

   metadata = 'LIC_FILES_CHKSUM'
   license  = 'LICENSE'

 But the way  it is present need some improvement. We should not be
 listing all licenses, just the ones that change.

 Leo


 On Thu, Oct 26, 2017 at 11:32 AM, Patchwork
 <[email protected]> wrote:
 >== Series Details ==
 >
 >Series: linux-firmware: Bump to bf04291 revision
 >Revision: 1
 >URL   : https://patchwork.openembedded.org/series/9498/
 >State : failure
 >
 >== Summary ==
 >
 >
 >Thank you for submitting this patch series to OpenEmbedded Core.
 >This is
 >an automated response. Several tests have been executed on the
 >proposed
 >series by patchtest resulting in the following failures:
 >
 >
 >
 >* Issue             LIC_FILES_CHKSUM changed on target
 >linux-firmware but there was no explanation as to why in the
 >commit message [test_lic_files_chksum_modified_not_mentioned]
 >  Suggested fix    Provide a reason for LIC_FILES_CHKSUM change in
 >commit message
 >  Current checksum
 >file://LICENCE.Abilis;md5=b5ee3f410780e56711ad48eadc22b8bc
 >file://LICENCE.adsp_sst;md5=615c45b91a5a4a9fe046d6ab9a2df728
 >file://LICENCE.agere;md5=af0133de6b4a9b2522defd5f188afd31
 >file://LICENSE.amdgpu;md5=0aa3c2f3e736af320a08a3aeeccecf29
 >file://LICENSE.amd-ucode;md5=3a0de451253cc1edbf30a3c621effee3

>file://LICENCE.atheros_firmware;md5=30a14c7823beedac9fa39c64fdd01a13

 >file://LICENSE.atmel;md5=aa74ac0c60595dee4d4e239107ea77a3

>file://LICENCE.broadcom_bcm43xx;md5=3160c14df7228891b868060e1951dfbc

 >file://LICENCE.ca0132;md5=209b33e66ee5be0461f13d31da392198
 >file://LICENCE.cavium;md5=c37aaffb1ebe5939b2580d073a95daea

>file://LICENCE.chelsio_firmware;md5=819aa8c3fa453f1b258ed8d168a9d903

 >file://LICENCE.cw1200;md5=f0f770864e7a8444a5c5aa9d12a3a7ed
 >file://LICENSE.dib0700;md5=f7411825c8a555a1a3e5eab9ca773431
 >file://LICENCE.e100;md5=ec0f84136766df159a3ae6d02acdf5a8
 >file://LICENCE.ene_firmware;md5=ed67f0f62f8f798130c29
 > 6720b7d3921
 >file://LICENCE.fw_sst_0f28;md5=6353931c988ad52818ae733ac61cd293
 >file://LICENCE.go7007;md5=c0bb9f6aaaba55b0529ee9b30aa66beb
 >file://GPL-2;md5=b234ee4d69f5fce4486a80fdaf4a4263
 >file://LICENSE.hfi1_firmware;md5=5e7b6e586ce7339d12689e49931ad444
 >file://LICENCE.i2400m;md5=14b901969e23c41881327c0d9e4b7d36
 >file://LICENSE.i915;md5=2b0b2e0d20984affd4490ba2cba02570
 >file://LICENCE.ibt_firmware;md5=fdbee1ddfe0fb7ab0b2fcd6b454a366b
 >file://LICENCE.IntcSST2;md5=9e7d8bea77612d7cc7d9e9b54b623062
 >file://LICENCE.it913x;md5=1fbf727bfb6a949810c4dbfa7e6ce4f8

>file://LICENCE.iwlwifi_firmware;md5=3fd842911ea93c29cd32679aa23e1c88

 >file://LICENCE.kaweth;md5=b1d876e562f4b3b8d391ad8395dfe03f
 >file://LICENCE.Marvell;md5=9ddea1734a4baf3c78d845151f42a37a

>file://LICENCE.moxa;md5=1086614767d8ccf744a923289d3d4261file://LICENCE.myri10ge_firmware;md5=42e32fb89f6b959ca222e25ac8df8fed

 >file://LICENCE.Netronome;md5=cd2a3e6effe3cdf42731575b8e9477ed
 >     file://LICENCE.nvidia;md5=4428a922ed3ba2ceec95f076a488ce07

>file://LICENCE.OLPC;md5=5b917f9d8c061991be4f6f5f108719cdfile://LICENCE.open-ath9k-htc-firmware;md5=1b33c9f4d17bc4d457bdb23727046837

 >file://LICENCE.phanfw;md5=954dcec0e051f9409812b561ea743bfa
 >file://LICENCE.qat_firmware;md5=9e7d8bea77612d7cc7d9e9b54b623062
 >file://LICENCE.qla1280;md5=d6895732e622d950609093223a2c4f5d

>file://LICENCE.qla2xxx;md5=505855e921b75f1be4a437ad9b79dff0file://LICENSE.QualcommAtheros_ar3k;md5=b5fe244fb2b532311de1472a3bc06da5file://LICENSE.QualcommAtheros_ath10k;md5=cb42b686ee5f5cb890275e4321db60a8

 >file://LICENCE.r8a779x_usb3;md5=4c1671656153025d7076105a5da7e498

>file://LICENSE.radeon;md5=68ec28bacb3613200bca44f404c69b16file://LICENCE.ralink_a_mediatek_company_firmware;md5=728f1a85fd53fd67fa8d7afb080bc435file://LICENCE.ralink-firmware.txt;md5=ab2c269277c45476fb449673911a2dfd

 >file://LICENCE.rtlwifi_firmware.txt;md5=00d06cfd3eddd5a2698948ead2
 > ad54a5
 >file://LICENSE.sdma_firmware;md5=51e8c19ecc2270f4b8ea30341ad63ce9

>file://LICENCE.siano;md5=4556c1bf830067f12ca151ad953ec2a5file://LICENCE.tda7706-firmware.txt;md5=835997cf5e3c131d0dddd695c7d9103e

 >file://LICENCE.ti-connectivity;md5=c5e02be633f1499c109d1652514d85ec

>file://LICENCE.ti-keystone;md5=3a86335d32864b0bef996bee26cc0f2cfile://LICENCE.ueagle-atm4-firmware;md5=4ed7ea6b507ccc583b9d594417714118

 >file://LICENCE.via_vt6656;md5=e4159694cba42d4377a912e78a6e850f
 >file://LICENCE.wl1251;md5=ad3f81922bb9e197014bb187289d3b5b
 >file://LICENCE.xc4000;md5=0ff51d2dc49fce04814c9155081092f0
 >file://LICENCE.xc5000;md5=1e170c13175323c32c7f4d0998d53f66
 >file://LICENCE.xc5000c;md5=12b02efa3049db65d524aeb418dd87ca
 >file://WHENCE;md5=08f6d4371353cac5f6fc271d5407c63e
 >  New checksum
 >file://LICENCE.Abilis;md5=b5ee3f410780e56711ad48eadc22b8bc
 >file://LICENCE.adsp_sst;md5=615c45b91a5a4a9fe046d6ab9a2df728
 >file://LICENCE.agere;md5=af0133de6b4a9b2522defd5f188afd31
 >file://LICENSE.amdgpu;md5=0aa3c2f3e736af320a08a3aeeccecf29
 >file://LICENSE.amd-ucode;md5=3a0de451253cc1edbf30a3c621effee3