On 17-12-01 11:43 -0600, Mark Hatle wrote: > The original implementation did not include the ',' options because different > versions of file (as well as different architectures) would return different > strings. > > They all contains the same information, but order and inclusion of ',' changed > regularly. > > So I would caution that for this to check out a wide variety of host systems > and > architectures would need to be verified. (It's very possible that all modern > systems now conform to a single standard...) > > (The rest of the serious looks like a very good improvement, and I've got no > further comments on that.)
I was a little bit worried about this, thanks, this is useful feedback. Perhaps dropping the "," while still retaining the whitespace delimitation could be enough, and still work with a variety of file implementations? And while we're talking portability, is the use of GNU file's --brief option a problem (as introduced by another patch in this series)? It isn't specified in posix, I don't know how widespread it is. -- olofjn -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
