On 01/03/2018 06:59 PM, Bystricky, Juro wrote:
A technicality: do not patch mnacros.in, set the macro directly from
package_rpm.bbclass.
Yes, I considered this (see the [patch 0/1]). I chose to patch macros.in in the
recipe rpm_4.14.0 instead because the new macro is introduced in RPM 4.14.0.
I assumed we did not want to have RPM version dependencies in
package_rpm.bbclass.
But I have no strong feelings regarding this, I am pretty sure the new macro is
here
to stay in the future and it is unlikely anyone would want to use a pre-4.14.0
version of RPM either. If you think patching package_rpm.bbclass makes more
sense,
I can send in another patch.
Yes please. Setting configuration options at runtime is always
preferable to patching the upstream source code, for maintainability
reasons. We are already drowning in patches.
Alex
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
