Hi Martin,

On 03/08/2018 01:25 PM, Manjukumar Harthikote Matha wrote:
Hi Martin,

-----Original Message-----
From: Martin Hundebøll [mailto:m...@prevas.dk]
Sent: Wednesday, March 07, 2018 11:26 PM
To: Vineeth Karumanchi <vinee...@xilinx.com>; openembedded-
c...@lists.openembedded.org; Manjukumar Harthikote Matha
<manju...@xilinx.com>
Subject: Re: [OE-core] [PATCH] kernel-fitimage.bbclass: Deploy fitImage without
Initramfs

Hi Vineeth,

On 2018-03-07 15:41, Vineeth Chowdary Karumanchi wrote:
This patch deploys fitImage (linux.bin + dtb ).
The use case is to have 2 partioned sd card, with FAT partition having
bootloader + fitImage and
ext4 partion having rootfs.

Signen-off-by: Vineeth Chowdary Karumanchi
<vineethchowz.chowd...@xilinx.com>
---
   meta/classes/kernel-fitimage.bbclass | 5 +++++
   1 file changed, 5 insertions(+)

diff --git a/meta/classes/kernel-fitimage.bbclass
b/meta/classes/kernel-fitimage.bbclass
index 50a91e1..25884d5 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -464,6 +464,10 @@ kernel_do_deploy_append() {
                  
linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-
${DATETIME}"
                  linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
                  install -m 0644 linux.bin
${DEPLOYDIR}/${linux_bin_base_name}.bin
+               fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-
${DATETIME}"
+               fitimage_symlink_name=fitImage-${MACHINE}
+               install -m 0644 arch/${ARCH}/boot/fitImage
+ ${DEPLOYDIR}/${fitimage_base_name}.bin
+

Isn't this already handled by the "linux_bin_base_name" variable just above 
(i.e.
fitImahe-linux.bin-${MACHINE}).

It is linux.bin which is generated at the time of fitImage creation.

- linux.bin and arch/${ARCH}/boot/fitImage differ,
- uboot fails to recognise linux.bin
- arch/${ARCH}/boot/fitImage is the fitimage.

Thanks
VIneeth

I have various fitimages, and as far as I recall, a
non-initramfs fitimage is already deployed.

This patch seems to do the right thing.

linux.bin is being copied as fitImage-linux.bin-${MACHINE} , and I think it is 
incorrect.
It should be fitImage, which is generated in do_assemble_fitimage

If you look at initramfs case:
install -m 0644 arch/${ARCH}/boot/fitImage-${INITRAMFS_IMAGE} 
${DEPLOYDIR}/${fit_initramfs_base_name}.bin which is correct

Thanks,
Manju


--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to