On Fri, 2018-03-09 at 17:56 +0000, Manjukumar Harthikote Matha wrote: > > > > > -----Original Message----- > > From: Richard Purdie [mailto:[email protected]] > > Sent: Friday, March 09, 2018 5:27 AM > > To: Bhargava Sreekantappa Gayathri <[email protected]>; > > openembedded- > > [email protected]; Manjukumar Harthikote Matha > > <[email protected]> > > Subject: Re: [OE-core] [PATCH] own-mirrors.bbclass: Change prepend > > to append > > > > On Thu, 2018-03-08 at 17:49 -0800, Bhargava Sreekantappa Gayathri > > wrote: > > > > > > If BB_NO_NETWORK is set to 1, and local download directory is > > > added as > > > PREMIRRORS_prepend in conf file, PREMIRRORS variable will have > > > SOURCE_MIRROR_URL as the first url. This causes build to fail as > > > network access is diabled. PREMIRRORS should be appended here so > > > that > > > a prepend in other layers/conf files takes precedence. > > > > > > Signed-off-by: Bhargava Sreekantappa Gayathri > > > <bhargava.sreekantappa- > > > [email protected]> > > > Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xili > > > nx.c > > > om> > > > --- > > > meta/classes/own-mirrors.bbclass | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I think this patch just moves the problem, you could easily have a > > file:/// url > > as SOURCE_MIRROR_URL and a network address in your other layer in > > which case > > your patch would break things... > > > > Agreed. > I think the better fix would be to go through the entire available > list in PREMIRRORS skipping http or https (since BB_NO_NETWORK is > set) and then fail if we cannot get the required file.
Agreed, we just need to ensure users see a mention that BB_NO_NETWORK is set in those failure modes. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
