Carried on thinking after sending this and I now think that in a SDK
we probably want to enforce all-or-nothing and this is the easiest
way.

Can you expand the commit message so the rationale doesn't get lost?

Ross

On 9 April 2018 at 14:54, Burton, Ross <ross.bur...@intel.com> wrote:
> That's definitely a hack.  If SDKs should contain Python then install
> python3 (which will install -core and -modules), if not then don't
> install it.  The corner-case is a SDK which though dependencies
> installs half a Python, in which case I'd say you should just
> explicitly add all of Python.
>
> Ross
>
>
>
> On 7 April 2018 at 16:37, Tom Hochstein <tom.hochst...@nxp.com> wrote:
>> A colleague pointed out that what we installed in the SDK for python 3 was 
>> not functional, and that a minimal set of modules was required.  I'm not an 
>> expert, but I found a similar line in the python 2 recipe and thought it 
>> might be what was needed here.
>>
>> Tom
>>
>> -----Original Message-----
>> From: Richard Purdie [mailto:richard.pur...@linuxfoundation.org]
>> Sent: Thursday, April 5, 2018 8:56 AM
>> To: Tom Hochstein <tom.hochst...@nxp.com>; 
>> openembedded-core@lists.openembedded.org
>> Subject: Re: [OE-core] [PATCH] python3: Add recommended modules to nativesdk 
>> install
>>
>> On Wed, 2018-04-04 at 14:25 -0500, Tom Hochstein wrote:
>>> The python3 installation in the SDK did not include the minimum set of
>>> modules.
>>>
>>> Signed-off-by: Tom Hochstein <tom.hochst...@nxp.com>
>>> ---
>>>  meta/recipes-devtools/python/python3_3.5.5.bb | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-devtools/python/python3_3.5.5.bb
>>> b/meta/recipes-devtools/python/python3_3.5.5.bb
>>> index d458d32..f893b84 100644
>>> --- a/meta/recipes-devtools/python/python3_3.5.5.bb
>>> +++ b/meta/recipes-devtools/python/python3_3.5.5.bb
>>> @@ -211,6 +211,7 @@ py_package_preprocess () {
>>>
>>>  # manual dependency additions
>>>  RPROVIDES_${PN}-modules = "${PN}"
>>> +RRECOMMENDS_${PN}-core_append_class-nativesdk = " nativesdk-python3-
>>> modules"
>>>  RRECOMMENDS_${PN}-crypt = "openssl"
>>>  RRECOMMENDS_${PN}-crypt_class-nativesdk = "nativesdk-openssl"
>>
>> This doesn't look correct, if you want the SDK to contain all python 
>> modules, surely you'd just add nativesdk-python3-modules rather than forcing 
>> this everywhere?
>>
>> Cheers,
>>
>> Richard
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to