Noted, will add comment and resend the patch. Thank you for your inputs. 

-----Original Message-----
From: Alexander Kanavin [mailto:alexander.kana...@linux.intel.com] 
Sent: Monday, April 9, 2018 8:34 PM
To: Yeoh, Ee Peng <ee.peng.y...@intel.com>; 
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] oe-selftest: runqemu: add tests for qemu boot 
and shutdown

On 04/09/2018 06:32 AM, Yeoh Ee Peng wrote:
> QA team were testing qemu boot image and shutdown on each qemu 
> architecture manually. Add automated test to test qemu boot on
> ext4 and nfs, finally check that it can shutdown properly.
> 
> Signed-off-by: Yeoh Ee Peng <ee.peng.y...@intel.com>
> ---
>   meta/lib/oeqa/selftest/cases/runqemu.py | 61 
> +++++++++++++++++++++++++++++++--
>   1 file changed, 59 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/runqemu.py 
> b/meta/lib/oeqa/selftest/cases/runqemu.py
> index 47d41f5..7288ab2 100644
> --- a/meta/lib/oeqa/selftest/cases/runqemu.py
> +++ b/meta/lib/oeqa/selftest/cases/runqemu.py
> @@ -3,9 +3,10 @@
>   #
>   
>   import re
> -
> +import tempfile
> +import time
>   from oeqa.selftest.case import OESelftestTestCase -from 
> oeqa.utils.commands import bitbake, runqemu, get_bb_var
> +from oeqa.utils.commands import bitbake, runqemu, get_bb_var, runCmd
>   from oeqa.core.decorator.oeid import OETestID
>   
>   class RunqemuTests(OESelftestTestCase):
> @@ -136,3 +137,59 @@ SYSLINUX_TIMEOUT = "10"
>           cmd = "%s %s" % (self.cmd_common, rootfs)
>           with runqemu(self.recipe, ssh=False, launch_cmd=cmd) as qemu:
>               self.assertTrue(qemu.runner.logged, "Failed: %s" % cmd)
> +
> +class QemuTest(OESelftestTestCase):

Please add comments that explain the need for a separate class, what the two 
classes do and how they differ.


Alex
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to