On Thu, Apr 12, 2018 at 11:26 AM, Alistair Francis <[email protected]> wrote: > On Thu, Apr 12, 2018 at 8:49 AM, Khem Raj <[email protected]> wrote: >> On 4/10/18 10:09 AM, Alistair Francis wrote: >>> If a user has specified numa in their DISTRO_FEATURES then they should >>> have NUMA support enabled in the kernel. Without kernel support the >>> numactl program is not very useful. >>> >> >> This should be done in OE-Core as part of main recipe. > > Do you mean in core linux-yocto > (meta/recipes-kernel/linux/linux-yocto.inc)? That seemed a little odd > to me as the numactl package comes from the meta-oe layer. I was > thinking it made sense to keep them together. >
its controlled by a distro feature which would add right knobs to it in core. it wont be changing any functionality therefore and hence would be ok > Alistair > >> >> Note that this patch is sent to oe-core ml but is actually against >> meta-oe layer which follows oe-devel mailing list. >> >>> Signed-off-by: Alistair Francis <[email protected]> >>> --- >>> meta-oe/recipes-kernel/linux/linux-yocto.inc | 2 ++ >>> meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend | 1 + >>> meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend | 1 + >>> meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend | 1 + >>> meta-oe/recipes-support/numactl/numactl/numa.cfg | 2 ++ >>> meta-oe/recipes-support/numactl/numactl_git.bb | 1 + >>> 6 files changed, 8 insertions(+) >>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto.inc >>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend >>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend >>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend >>> create mode 100644 meta-oe/recipes-support/numactl/numactl/numa.cfg >>> >>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto.inc >>> b/meta-oe/recipes-kernel/linux/linux-yocto.inc >>> new file mode 100644 >>> index 0000000..9533eb6 >>> --- /dev/null >>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto.inc >>> @@ -0,0 +1,2 @@ >>> +KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'numa', >>> 'features/numa/numa.scc', '', d)}" >>> + >>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend >>> b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend >>> new file mode 100644 >>> index 0000000..161f9d3 >>> --- /dev/null >>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend >>> @@ -0,0 +1 @@ >>> +require linux-yocto.inc >>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend >>> b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend >>> new file mode 100644 >>> index 0000000..161f9d3 >>> --- /dev/null >>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend >>> @@ -0,0 +1 @@ >>> +require linux-yocto.inc >>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend >>> b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend >>> new file mode 100644 >>> index 0000000..161f9d3 >>> --- /dev/null >>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend >>> @@ -0,0 +1 @@ >>> +require linux-yocto.inc >>> diff --git a/meta-oe/recipes-support/numactl/numactl/numa.cfg >>> b/meta-oe/recipes-support/numactl/numactl/numa.cfg >>> new file mode 100644 >>> index 0000000..fe1394d >>> --- /dev/null >>> +++ b/meta-oe/recipes-support/numactl/numactl/numa.cfg >>> @@ -0,0 +1,2 @@ >>> +CONFIG_NUMA=y >>> +CONFIG_ACPI_NUMA=y >>> diff --git a/meta-oe/recipes-support/numactl/numactl_git.bb >>> b/meta-oe/recipes-support/numactl/numactl_git.bb >>> index b9cbcf0..ef2dab2 100644 >>> --- a/meta-oe/recipes-support/numactl/numactl_git.bb >>> +++ b/meta-oe/recipes-support/numactl/numactl_git.bb >>> @@ -21,6 +21,7 @@ SRC_URI = "git://github.com/numactl/numactl \ >>> file://run-ptest \ >>> file://0001-define-run-test-target.patch \ >>> " >>> +SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'numa', ' >>> file://numa.cfg', '', d)}" >>> >>> S = "${WORKDIR}/git" >>> >>> >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> [email protected] >> http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
