On Wednesday 02 May 2018 at 08:39:27 +0000, Peter Kjellerstedt wrote:
> > if ${@bb.utils.contains('PACKAGECONFIG', 'udev', 'false', 'true', d)};
> > then
>
> I suggest that you remove the if-statement since the /unwanted directory
> shall always be removed if it exists so there is no need to test for it.
I had wondered about doing that myself, but had decided to make as few
changes as possible.
> > - # This is where alsa-utils will install its rules if we don't
> > tell it anything else.
> > - rm -rf ${D}${nonarch_base_libdir}/udev
> > - rmdir --ignore-fail-on-non-empty ${D}${nonarch_base_libdir}
> > + # If udev is disabled, we told configure to install the rules
> > in /unwanted, so
> > + # we can get rid of them now.
> > + rm -rf ${D}/unwanted
>
> Correct the indentation (the rest of the function is indented using
> tabs).
I'd spotted that, and had thought that I'd sorted it out. It turns out that
I ended up making it even worse with a mixture of spaces and tabs. :(
Hopefully v2 is better.
Thanks.
Mike.
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
