Hi,

Please ignore below patch.
I will send a V2 taking care of comments from Richard.

Thanks,
Devarsh

> -----Original Message-----
> From: openembedded-core-boun...@lists.openembedded.org
> [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of
> openembedded-core-requ...@lists.openembedded.org
> Sent: Monday, June 11, 2018 2:11 PM
> To: openembedded-core@lists.openembedded.org
> Subject: Openembedded-core Digest, Vol 89, Issue 101
> 
> Send Openembedded-core mailing list submissions to
>       openembedded-core@lists.openembedded.org
> 
> To subscribe or unsubscribe via the World Wide Web, visit
>       http://lists.openembedded.org/mailman/listinfo/openembedded-core
> or, via email, send a message with subject or body 'help' to
>       openembedded-core-requ...@lists.openembedded.org
> 
> You can reach the person managing the list at
>       openembedded-core-ow...@lists.openembedded.org
> 
> When replying, please edit your Subject line so it is more specific than "Re:
> Contents of Openembedded-core digest..."
> 
> 
> Today's Topics:
> 
>    1. [PATCH] matchbox-terminal: Update commitID (Devarsh Thakkar)
>    2. Re: [PATCH 2/2] bitbake-blayers/create: add
>       LAYERSERIES_COMPAT (Richard Purdie)
>    3. [PATCH] xinetd: Fix systemd service for systemd>237
>       (Ricardo Ribalda Delgado)
>    4. [PATCH v2] bitbake-blayers/create: add LAYERSERIES_COMPAT
>       (Anuj Mittal)
>    5. Re: [PATCH v2] bitbake-blayers/create: add LAYERSERIES_COMPAT
>       (Peter Kjellerstedt)
> 
> 
> ----------------------------------------------------------------------
> 
> Message: 1
> Date: Sun, 10 Jun 2018 23:22:24 -0700
> From: Devarsh Thakkar <devarsh.thak...@xilinx.com>
> To: <openembedded-core@lists.openembedded.org>, <devar...@xilinx.com>
> Subject: [OE-core] [PATCH] matchbox-terminal: Update commitID
> Message-ID: <1528698144-25780-1-git-send-email-devar...@xilinx.com>
> Content-Type: text/plain
> 
> Pull in change which adds support for command line options (-e and --
> command) which can be used for launching programs or running commands in
> matchbox-terminal via command line.
> 
> Signed-off-by: Devarsh Thakkar <devar...@xilinx.com>
> ---
>  meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> index 4488191..b7fbee7 100644
> --- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> +++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
>  SECTION = "x11/utils"
> 
>  #SRCREV tagged 0.1
> -SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
> +SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
>  SRC_URI = "git://git.yoctoproject.org/${BPN}"
>  UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
> 
> --
> 2.1.1
> 
> This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any 
> attachments.
> Delete this email message and any attachments immediately.
> 
> 
> ------------------------------
> 
> Message: 2
> Date: Mon, 11 Jun 2018 08:21:25 +0100
> From: Richard Purdie <richard.pur...@linuxfoundation.org>
> To: Anuj Mittal <anuj.mit...@intel.com>,
>       openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/2] bitbake-blayers/create: add
>       LAYERSERIES_COMPAT
> Message-ID:
>       <4c3a2b83203d7c07affbd12ff5300f11d516e002.camel@linuxfoundati
> on.org>
> Content-Type: text/plain; charset="UTF-8"
> 
> On Mon, 2018-06-11 at 09:52 +0800, Anuj Mittal wrote:
> > Derive the value for template layer.conf from core layer and add
> > dependendency on it too.
> >
> > Fixes [YOCTO #12767]
> >
> > Signed-off-by: Anuj Mittal <anuj.mit...@intel.com>
> > ---
> >  meta/lib/bblayers/create.py            | 2 +-
> >  meta/lib/bblayers/templates/layer.conf | 3 +++
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/lib/bblayers/create.py b/meta/lib/bblayers/create.py
> > index c1923166fd..d9699b21f9 100644
> > --- a/meta/lib/bblayers/create.py
> > +++ b/meta/lib/bblayers/create.py
> > @@ -44,7 +44,7 @@ class CreatePlugin(LayerPlugin):
> >          shutil.copy(license_src, license_dst)
> >
> >          # Create the layer.conf from templates/layer.conf
> > -        layerconf_template = read_template('layer.conf') %
> > (args.layerdir, args.layerdir, args.layerdir, args.priority)
> > +        layerconf_template = read_template('layer.conf') %
> > (args.layerdir, args.layerdir, args.layerdir, args.priority,
> > args.layerdir, args.layerdir)
> >          layerconf = os.path.join(conf, 'layer.conf')
> >          with open(layerconf, 'w') as fd:
> >              fd.write(layerconf_template) diff --git
> > a/meta/lib/bblayers/templates/layer.conf
> > b/meta/lib/bblayers/templates/layer.conf
> > index 3c0300226c..61b3ad8db3 100644
> > --- a/meta/lib/bblayers/templates/layer.conf
> > +++ b/meta/lib/bblayers/templates/layer.conf
> > @@ -8,3 +8,6 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
> > BBFILE_COLLECTIONS += "%s"
> >  BBFILE_PATTERN_%s = "^${LAYERDIR}/"
> >  BBFILE_PRIORITY_%s = "%s"
> > +
> > +LAYERDEPENDS_%s = "core"
> > +LAYERSERIES_COMPAT_%s = "${LAYERSERIES_COMPAT_core}"
> 
> I feel very strongly that we do not want to just copy and paste this "follow
> core" value around. The template needs to contain an expanded value so that
> when core changes, people need to update their layer to say what they're
> compatible with.
> 
> Cheers,
> 
> Richard
> 
> 
> ------------------------------
> 
> Message: 3
> Date: Mon, 11 Jun 2018 10:05:04 +0200
> From: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
> To: openembedded-core@lists.openembedded.org,
>       chong...@windriver.com
> Subject: [OE-core] [PATCH] xinetd: Fix systemd service for systemd>237
> Message-ID: <20180611080504.16006-1-ricardo.riba...@gmail.com>
> 
> SystemD 237 implements a stricted PIDfile handling that breaks several
> daemons [1].
> 
> Change the way we start xinetd, mimicing other distros [2].
> 
> Fixes:
> root@qt5122:~# journalctl -u xinetd
> -- Logs begin at Fri 2018-05-25 14:33:29 UTC, end at Mon 2018-06-11 07:33:08
> UTC. -- May 25 14:33:31 qt5122 systemd[1]: Starting Xinetd A Powerful
> Replacement For Inetd...
> May 25 14:33:31 qt5122 systemd[1]: xinetd.service: Permission denied while
> opening PID file or unsafe symlink chain: /var/run/xinetd.pid Jun 11 07:27:24
> qt5122 systemd[1]: xinetd.service: Start operation timed out. Terminating.
> Jun 11 07:27:24 qt5122 systemd[1]: xinetd.service: Failed with result 
> 'timeout'.
> Jun 11 07:27:24 qt5122 systemd[1]: Failed to start Xinetd A Powerful
> Replacement For Inetd.
> Jun 11 07:31:38 qt5122 systemd[1]: Starting Xinetd A Powerful Replacement
> For Inetd...
> Jun 11 07:31:38 qt5122 systemd[1]: xinetd.service: Permission denied while
> opening PID file or unsafe symlink chain: /var/run/xinetd.pid Jun 11 07:33:08
> qt5122 systemd[1]: xinetd.service: Start operation timed out. Terminating.
> Jun 11 07:33:08 qt5122 systemd[1]: xinetd.service: Failed with result 
> 'timeout'.
> Jun 11 07:33:08 qt5122 systemd[1]: Failed to start Xinetd A Powerful
> Replacement For Inetd.
> 
> [1]: https://github.com/systemd/systemd/issues/8085
> [2]: https://github.com/felixonmars/archlinux-
> community/commit/e49040636737fdb09031e75ec4d73a580f80676b
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
> ---
>  meta/recipes-extended/xinetd/xinetd/xinetd.service | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/meta/recipes-extended/xinetd/xinetd/xinetd.service
> b/meta/recipes-extended/xinetd/xinetd/xinetd.service
> index d5fdc5bc29..6da92f2bf5 100644
> --- a/meta/recipes-extended/xinetd/xinetd/xinetd.service
> +++ b/meta/recipes-extended/xinetd/xinetd/xinetd.service
> @@ -3,11 +3,8 @@ Description=Xinetd A Powerful Replacement For Inetd
> After=syslog.target network.target
> 
>  [Service]
> -Type=forking
> -PIDFile=/var/run/xinetd.pid
>  EnvironmentFile=-/etc/sysconfig/xinetd
> -ExecStart=@SBINDIR@/xinetd -stayalive -pidfile /var/run/xinetd.pid
> "$EXTRAOPTIONS"
> -ExecReload=@BASE_BINDIR@/kill -HUP $MAINPID
> +ExecStart=@SBINDIR@/xinetd -dontfork "$EXTRAOPTIONS"
> 
>  [Install]
>  WantedBy=multi-user.target
> --
> 2.17.1
> 
> 
> 
> ------------------------------
> 
> Message: 4
> Date: Mon, 11 Jun 2018 16:29:01 +0800
> From: Anuj Mittal <anuj.mit...@intel.com>
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH v2] bitbake-blayers/create: add
>       LAYERSERIES_COMPAT
> Message-ID: <20180611082901.28043-1-anuj.mit...@intel.com>
> 
> Derive the value for template layer.conf from core layer and add
> dependendency on it too.
> 
> Fixes [YOCTO #12767]
> 
> Signed-off-by: Anuj Mittal <anuj.mit...@intel.com>
> ---
>  meta/lib/bblayers/create.py            | 5 ++++-
>  meta/lib/bblayers/templates/layer.conf | 3 +++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/lib/bblayers/create.py b/meta/lib/bblayers/create.py
> index c1923166fd..e06949c92b 100644
> --- a/meta/lib/bblayers/create.py
> +++ b/meta/lib/bblayers/create.py
> @@ -43,8 +43,11 @@ class CreatePlugin(LayerPlugin):
>          license_dst = os.path.join(layerdir, copying)
>          shutil.copy(license_src, license_dst)
> 
> +        # Get the compat value for core layer.
> +        compat = self.tinfoil.config_data.getVar('LAYERSERIES_COMPAT_core') 
> or
> ""
> +
>          # Create the layer.conf from templates/layer.conf
> -        layerconf_template = read_template('layer.conf') % (args.layerdir,
> args.layerdir, args.layerdir, args.priority)
> +        layerconf_template = read_template('layer.conf') % (args.layerdir,
> args.layerdir, args.layerdir, args.priority, args.layerdir, args.layerdir, 
> compat)
>          layerconf = os.path.join(conf, 'layer.conf')
>          with open(layerconf, 'w') as fd:
>              fd.write(layerconf_template)
> diff --git a/meta/lib/bblayers/templates/layer.conf
> b/meta/lib/bblayers/templates/layer.conf
> index 3c0300226c..49f95cafc8 100644
> --- a/meta/lib/bblayers/templates/layer.conf
> +++ b/meta/lib/bblayers/templates/layer.conf
> @@ -8,3 +8,6 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
>  BBFILE_COLLECTIONS += "%s"
>  BBFILE_PATTERN_%s = "^${LAYERDIR}/"
>  BBFILE_PRIORITY_%s = "%s"
> +
> +LAYERDEPENDS_%s = "core"
> +LAYERSERIES_COMPAT_%s = "%s"
> --
> 2.17.1
> 
> 
> 
> ------------------------------
> 
> Message: 5
> Date: Mon, 11 Jun 2018 08:41:10 +0000
> From: Peter Kjellerstedt <peter.kjellerst...@axis.com>
> To: Anuj Mittal <anuj.mit...@intel.com>,
>       "openembedded-core@lists.openembedded.org"
>       <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH v2] bitbake-blayers/create: add
>       LAYERSERIES_COMPAT
> Message-ID: <1128577de36d44109f83bf3260386...@xbox02.axis.com>
> Content-Type: text/plain; charset="us-ascii"
> 
> > -----Original Message-----
> > From: openembedded-core-boun...@lists.openembedded.org
> > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of
> > Anuj Mittal
> > Sent: den 11 juni 2018 10:29
> > To: openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [PATCH v2] bitbake-blayers/create: add
> LAYERSERIES_COMPAT
>                                 ^^^^^^^^^^^^^^^
> I assume you mean "bitbake-layers"... This goes for the other
> patch in the series as well.
> 
> //Peter
> 
> 
> 
> ------------------------------
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> End of Openembedded-core Digest, Vol 89, Issue 101
> **************************************************
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to