On 07/28/2018 04:53 AM, Anuj Mittal wrote:
rm_work if enabled leads to some tests failing that rely on artifacts being present. Check if rm_work.bbclass is included and show an error and exit if it is.Fixes [YOCTO #12694] Signed-off-by: Anuj Mittal <anuj.mit...@intel.com> --- meta/lib/oeqa/selftest/context.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta/lib/oeqa/selftest/context.py b/meta/lib/oeqa/selftest/context.py index 16812ba96e..3a70f9e77b 100644 --- a/meta/lib/oeqa/selftest/context.py +++ b/meta/lib/oeqa/selftest/context.py @@ -187,6 +187,10 @@ class OESelftestTestContextExecutor(OETestContextExecutor): self.tc.logger.error("You have buildhistory enabled already and this isn't recommended for selftest, please disable it first.") raise OEQAPreRun+ if "rm_work.bbclass" in self.tc.td["BBINCLUDED"]:+ self.tc.logger.error("You have rm_work enabled which isn't recommended while running oe-selftest. Please disable it before continuing.") + raise OEQAPreRun + if "PRSERV_HOST" in self.tc.td: self.tc.logger.error("Please unset PRSERV_HOST in order to run oe-selftest") raise OEQAPreRun
Enabling rm_work should NOT be an error, and eventually it should not trigger any warnings. OEQA should only test the results of a build not how the build was done. I reviewed some of the rm_work related defects: 1. https://bugzilla.yoctoproject.org/show_bug.cgi?id=12647 The warning was intentional based on Paul's comment. 2. https://bugzilla.yoctoproject.org/show_bug.cgi?id=12655 The logs seem to only say that the error goes away when rm_work is NOT enabled. I'd prefer to understand what it is that's causing the failure and perhaps add to the packages recipe so that the output passes the OEQA tests. 3. https://bugzilla.yoctoproject.org/show_bug.cgi?id=12694 Title was: oe-selftest should warn if rm_work is enabled but the commit makes it an error. Any disagreement about making it be a warning? rm_work saves lots of storage space so I'm reluctant to make OEQA require that it is NOT used. -- # Randy MacLeod # Wind River Linux -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
