Subject:
Re: [OE-core] [oe-core][PATCH v3 2/2] runtime selftest: optimize the
case of hw_breakpoint
The subject/short log should be:
runtime selftest: limit kernel hw bp arches
Hongzhi.Song wrote:
>
> 1. So far, only qemux86 can support hw breakpoint
When I first read this, I thought that you really meant only
qemux86 and NOT qemux86-64. Of course you mean: qemux86* so
please say so using '*' or qemux86[-64].
Does this work with and without the host using the kvm module?
> qemuppc: Runqemu uses G4 as the default cpu. But qemu doesn't simulate
> the hw breakpoint register for G4, which belong to 74xx series.
Okay. Please change the wording to something like:
qemuppc: The oe-core configuration uses a PPC G4 system as the
default cpu but qemu doesn't simulate the hw breakpoint register for G4.
>
> qemuarm: The arch more than v7 supports hw breakpoint, however arm use
> v5 as default.
What about qemuarm64 and qemumips* ?
I don't care about mips so much but it would be nice if
qemuarm64 had this emulation. Oh, the patch code also allows
testing aarch64 so I guess qemuarm64 works. Please mention
that in the log in your first sentence.
>
> 2. Rsyslog maybe not started, so we use dmesg to confirm.
s/Rsyslog/syslog/
There are several syslog implementations so just refer to the
generic function.
>
> 3. Adding the operation of 'ls' triggers hardware breakpoint.
s/Adding the operation of 'ls' triggers hardware breakpoint.
/Run 'ls' to trigger the hardware breakpoint test.
/
Please take the numbering out of your long log.
If you read through the oe-core commits, you'll see that
people rarely number each statement. Numbered lists can be
used in cases such as:
5a7cf32967 openssl_1.0.2n: improve reproducibility
Almost done! :)
Other than the host kvm module question, and a clean-up
commit log, I think this is fine now.
I suspect that the glibc-2.28 upgrade is getting more attention
than this and other work so once the glibc upgrade is in master,
I'd hope that your V4 will be merged.
Thanks,
../Randy
Signed-off-by: Hongzhi.Song <[email protected]>
---
meta/lib/oeqa/runtime/cases/ksample.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/lib/oeqa/runtime/cases/ksample.py
b/meta/lib/oeqa/runtime/cases/ksample.py
index 26fbe9d8cb..eb8713351a 100644
--- a/meta/lib/oeqa/runtime/cases/ksample.py
+++ b/meta/lib/oeqa/runtime/cases/ksample.py
@@ -164,6 +164,11 @@ class KSampleTest(KSample):
# hw breakpoint
@OETestDepends(['ssh.SSHTest.test_ssh'])
def test_hw_breakpoint_example(self):
+ # check arch
+ status, output = self.target.run("uname -m")
+ result = ("x86" in output) or ("aarch64" in output)
+ if not result:
+ self.skipTest("the arch doesn't support hw breakpoint" % output)
# check config
self.check_config("CONFIG_KALLSYMS_ALL")
# make sure if module exists
--
# Randy MacLeod
# Wind River Linux
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
