On 2018-10-29 9:02 PM, Andre McCurdy wrote:
On Mon, Oct 29, 2018 at 11:13 AM Bruce Ashfield <[email protected]> wrote:As was warned by commit 312ee68752fa ("kconfig: announce removal of oldnoconfig if used"), it has been removed from the 4.20 kernel. So we switch our default mode to the proper olddefconfigMentioning which kernel version first introduced olddefconfig would be useful information here as kernels prior to that version will now fail to build. It looks like the patch was first proposed sometime around 2012: https://patchwork.kernel.org/patch/1394011/ We may also need to either add a fallback to use oldnoconfig or bump OLDEST_KERNEL (it's currently 3.2.0, which was released in early 2012 and so probably predates olddefconfig).
We've covered this a few times in the past, and yah, we could put a fallback into the command. I'll spin out a v2 that adds a fallback like we used to have, except now with the oldnoconfig as the 2nd option. Bruce
Signed-off-by: Bruce Ashfield <[email protected]> --- Not for the release, just wanted to get this in the queue for when master reopens so we'll be ready for 4.20+ kernel versions Bruce meta/classes/kernel.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index e04d2fe00434..d50f4a9ee822 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -492,7 +492,7 @@ sysroot_stage_all () { : } -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} oldnoconfig" +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig" python check_oldest_kernel() { oldest_kernel = d.getVar('OLDEST_KERNEL') -- 2.5.0 -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
