You should explain in the commit message -why- you made the change. It's already clear WHAT the change is, but not why you did it.
On 11/28/18 5:43 PM, Douglas Royds wrote: > Signed-off-by: Douglas Royds <[email protected]> > --- > meta/recipes-support/attr/acl_2.2.52.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-support/attr/acl_2.2.52.bb > b/meta/recipes-support/attr/acl_2.2.52.bb > index 8b89de9b42..318308a009 100644 > --- a/meta/recipes-support/attr/acl_2.2.52.bb > +++ b/meta/recipes-support/attr/acl_2.2.52.bb > @@ -41,8 +41,8 @@ inherit ptest > > do_install_ptest() { > tar -c --exclude=nfs test/ | ( cd ${D}${PTEST_PATH} && tar -xf - ) > - mkdir ${D}${PTEST_PATH}/include > - cp ${S}/include/builddefs ${S}/include/buildmacros > ${S}/include/buildrules ${D}${PTEST_PATH}/include/ > + install -d ${D}${PTEST_PATH}/include > + install -m 644 ${S}/include/builddefs ${S}/include/buildmacros > ${S}/include/buildrules ${D}${PTEST_PATH}/include/ > # Remove any build host references > sed -e "s:--sysroot=${STAGING_DIR_TARGET}::g" \ > -e 's:${HOSTTOOLS_DIR}/::g' \ > -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
