On Tue, 26 Mar 2019 at 11:02, Martin Jansa <[email protected]> wrote: > git fetcher fetches whatever SRCREV is defined in the recipe, no matter > what PV says, I've seen enough recipe upgrades which just renamed the > recipe to have new version in filename updating SRCREV and even claimed > that the upgrade was properly tested, because nothing got broken :). > > In webOS we got a bit further and PV+SRCREV are defined in one variable > WEBOS_VERSION and do_fetch qa check tests that the SRCREV points to > matching annotated version tag in the component.
Agreed that is a genuine problem and is definitely something patchtest should be catching these days. > Next time someone needs to include few bugfixes from stable branch > included just after the release, should he update the SRCREV or add them > as .patch files? Patches ideally, as we can pick them without other unintended changes. > FWIW: in webOS we don't use any version in filename, most recipes are > called just PN.bb and it works fine as well for us, less renames and > version consistently defined inside the recipes. That makes complete sense, PV in filename is pretty much legacy from the old days, along with recipes split into a bb/inc where there's only one recipe. Ross -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
