On 04/03/2019 10:12 PM, akuster808 wrote: > > > On 4/3/19 10:35 AM, Philip Balister wrote: >> I appreciate the nagging about testing, but I just did an update and >> realized these patches never made it into master so I could request they >> move into thud. > Thud needs testing too, its not just a master thing. > > It needs to be in warrior first ; ) > > Either send me the master/warrior commit ids or send a patch with the > proper subject so its clear to me. > But this looks like a new feature or am I misunderstanding?
New feature maybe, or bugfix for meta-xilinx. Without these, people using meta-xilinx may need to use thud + these changes. meta-xilinx/thud needs these to build properly: commit 084f4de4dbaf9821516fc0254d35f4fb04311d27 Author: Manjukumar Matha <[email protected]> Date: Wed Feb 20 10:29:06 2019 -0800 kernel-fitimage.bbclass: Introduce a way to provide external dtb Currently kernel-fitimage gets the dtb from KERNEL_DEVICETREE, however there are instances when the DTB file can be generated using other recipes, provide a way to include the DTB instead of inkernel device tree. Add support for external device tree during the creation of fitimage. If virtual/dtb is set using PREFERRED_PROVIDER_virtual/dtb = "devicetree", which inherits the devicetree.bbclass then use the path provided in EXTERNAL_KERNEL_DEVICETREE else use KERNEL_DEVICETREE during fitimage process Signed-off-by: Manjukumar Matha <[email protected]> Signed-off-by: Richard Purdie <[email protected]> ommit a7d52dbffd0da95de82d910c595a6c27d9b2ad0d Author: Manjukumar Matha <[email protected]> Date: Wed Feb 20 10:29:05 2019 -0800 devicetree.bbclass: Add virtual provider for dtb Add virtual provider for dtb. This class can be used to generate dtb from static devicetree, for reference see meta-xilinx layer meta-xilinx/meta-xilinx-bsp/recipes-bsp/device-tree/device-tree.bb By providing a virtual provider we can use it to differentiate between in-kernel dtb or an external one. This can be set in local.conf as PREFERRED_PROVIDER_virtual/dtb = "devicetree" Signed-off-by: Manjukumar Matha <[email protected]> Signed-off-by: Richard Purdie <[email protected]> > > - armin >> >> Philip >> >> On 02/21/2019 03:37 AM, Richard Purdie wrote: >>> On Thu, 2019-02-21 at 03:53 +0000, Manjukumar Harthikote Matha wrote: >>>> From: Richard Purdie [mailto:[email protected]] >>>>> On Tue, 2019-02-19 at 19:34 +0000, Manjukumar Harthikote Matha >>>>> >>>>>>> PREFERRED_PROVIDER_virtual/dtb = "devicetree" >>>>>>> >>>>>> Yes, I should have added this in the commit message. I will >>>>>> update it >>>>>> and re-send V2 >>>>> What may also help a lot here would be some tests. This is >>>>> currently a blackhole in >>>>> the tests :( >>>>> >>>> Are there examples of having tests only for bbclass in OE-Core? >>> There are. See meta/lib/oeqa/selftest/cases/wic.py >>> >>> I appreciate wic is a tool, not a class but the examples there should >>> help. You can trigger them with oe-selftest -r wic. >>> >>> Another example which is a bbclass is selftest/cases/archiver.py which >>> does use a class inherit. >>> >>>> We need a recipe or create-one to inherit this class and probably add >>>> that as a testcase. >>>> I am not sure how to proceed, any example would help to implement the >>>> same >>> See above, they show how to add small config fragments. If you do need >>> a full recipe, then the meta-selftest layer of OE-Core should be able >>> to help too. >>> >>> If you have any other questions or run into issues please do ask! >>> >>> Cheers, >>> >>> Richard >>> >>> >>> >>> > > -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
