Hi there, On Thu, May 02 2019 at 20:09 +0200, Marco Felsch <m.fel...@pengutronix.de> wrote: > Most the time we are compiling for embedded targets which have dedicated > hardware combinations. Setting swrast default on isn't a good solution > for such devices because if the hardware render node have an issue or > don't support a special format/request mesa will fallback to the > software renderer. This will make it harder to debug performace issues. > > A better way is to let the user deciced if a software renderer is > needed e.g. if the system has no hardware renderer or to have such a > fallback device. This way the user knows that the software renderer is > enabled. > > Upstream-Status: Submitted [openembedded-core@lists.openembedded.org] > > Signed-off-by: Marco Felsch <m.fel...@pengutronix.de> > --- > Changelog: > > v2: > - added Upstream-Status line > - fix leading comma > > meta/recipes-graphics/mesa/mesa.inc | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/meta/recipes-graphics/mesa/mesa.inc > b/meta/recipes-graphics/mesa/mesa.inc > index 7516a06639..b41d3054c3 100644 > --- a/meta/recipes-graphics/mesa/mesa.inc > +++ b/meta/recipes-graphics/mesa/mesa.inc > @@ -86,24 +86,27 @@ PACKAGECONFIG[egl] = "-Degl=true, -Degl=false" > > PACKAGECONFIG[etnaviv] = "" > PACKAGECONFIG[kmsro] = "" > +PACKAGECONFIG[swrast] = "" > > -GALLIUMDRIVERS = "swrast" > -GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG', 'etnaviv', > ',etnaviv', '', d)}" > -GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG', 'kmsro', > ',kmsro', '', d)}" > +GALLIUMDRIVERS = "" > +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'swrast', 'swrast', > '', d)}" > +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'etnaviv', > 'etnaviv', '', d)}" > +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'kmsro', 'kmsro', > '', d)}" > > # radeonsi requires LLVM > -GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600', > ',radeonsi', '', d)}" > +GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600', > 'radeonsi', '', d)}" > GALLIUMDRIVERS_LLVM33_ENABLED = > "${@oe.utils.version_less_or_equal('MESA_LLVM_RELEASE', '3.2', False, > len('${GALLIUMDRIVERS_LLVM33}') > 0, d)}" > -GALLIUMDRIVERS_LLVM = "r300,svga,nouveau${@',${GALLIUMDRIVERS_LLVM33}' if > ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}" > +GALLIUMDRIVERS_LLVM = "r300 svga nouveau ${@'${GALLIUMDRIVERS_LLVM33}' if > ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}" > > PACKAGECONFIG[r600] = "" > > -GALLIUMDRIVERS_append = "${@bb.utils.contains('PACKAGECONFIG', > 'gallium-llvm', ',${GALLIUMDRIVERS_LLVM}', '', d)}" > -GALLIUMDRIVERS_append = "${@bb.utils.contains('PACKAGECONFIG', 'r600', > ',r600', '', d)}" > -GALLIUMDRIVERS_append = ",virgl" > +GALLIUMDRIVERS += "${@bb.utils.contains('PACKAGECONFIG', 'gallium-llvm', > '${GALLIUMDRIVERS_LLVM}', '', d)}" > +GALLIUMDRIVERS += "${@bb.utils.contains('PACKAGECONFIG', 'r600', 'r600', '', > d)}" > +GALLIUMDRIVERS += "virgl" > +GALLIUMDRIVERS_MESON = "${@",".join("${GALLIUMDRIVERS}".split())}"
how does it have to look like if I want to go without this auxiliary variable GALLIUMDRIVERS_MESON and instead insert the Python expression that generates its content directly into ... > # keep --with-gallium-drivers separate, because when only one of gallium > versions is enabled, other 2 were adding --without-gallium-drivers > -PACKAGECONFIG[gallium] = "-Dgallium-drivers=${GALLIUMDRIVERS}, > -Dgallium-drivers=''" > +PACKAGECONFIG[gallium] = "-Dgallium-drivers=${GALLIUMDRIVERS_MESON}, > -Dgallium-drivers=''" ... the above assignment of PACKAGECONFIG[gallium]? I can't get it to work - perhaps it is a problem with escaping things? Best regards Ulrich > MESA_LLVM_RELEASE ?= "8.0.0" > PACKAGECONFIG[gallium-llvm] = "-Dllvm=true -Dshared-llvm=true, -Dllvm=false, > llvm${MESA_LLVM_RELEASE} llvm-native \ > ${@'elfutils' if > ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}" -- Pengutronix e.K. | Ulrich Ölmann | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core