Huh I checked git too. Obviously not well enough!
On Mon, 13 May 2019 at 20:22, Khem Raj <[email protected]> wrote: > > you are late to party but its already applied see oe-core/d5e999616e > > On Mon, May 13, 2019 at 7:27 PM Burton, Ross <[email protected]> wrote: > > > > https://github.com/systemd/systemd/commit/c98b3545008d8e984ab456dcf79787418fcbfe13 > > is the upstream fix, so lets use this instead. > > > > Ross > > > > On Mon, 6 May 2019 at 11:24, Adrian Bunk <[email protected]> wrote: > > > > > > On Mon, May 06, 2019 at 10:51:35AM -0700, Khem Raj wrote: > > > >... > > > > +gcc-9 has become a bit stricter and can check all kind of formatted > > > > +input/output functions which causes additional warnings when compiling > > > > +networkd > > > > + > > > > +/src/basic/log.h:104:9: error: ‘%s’ directive argument is null > > > > [-Werror=format-overflow=] > > > > + log_internal_realm(LOG_REALM_PLUS_LEVEL(LOG_REALM, (level)), > > > > __VA_ARGS__) > > > >... > > > > + if (r < 0) > > > > + log_link_warning_errno(link, r, "Cannot %s IPv6 for > > > > interface %s: %m", > > > > +- enable_disable(!disabled), > > > > link->ifname); > > > > ++ enable_disable(!disabled), > > > > ++ (link->ifname) ? link->ifname > > > > : "<null>"); > > > >... > > > > > > The fix doesn't look correct to me: > > > gcc says it "is null", so checking whether or not it is null doesn't > > > match the error message. > > > > > > If it is a compiler bug as was at some point mentioned upstream, > > > a better temporary workaround would be to stop making this an error > > > with -Wno-error=format-overflow (untested). > > > > > > cu > > > Adrian > > > > > > -- > > > > > > "Is there not promise of rain?" Ling Tan asked suddenly out > > > of the darkness. There had been need of rain for many days. > > > "Only a promise," Lao Er said. > > > Pearl S. Buck - Dragon Seed > > > > > > -- > > > _______________________________________________ > > > Openembedded-core mailing list > > > [email protected] > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
