On Thu, 2019-05-23 at 08:47 +0100, Nicola Lunghi wrote: > musl > 2.21 changed the implementation of the freeaddrinfo() function > not allowing anymore to pass null pointers to it. > This was causing a segmentation fault in connman. > --- > ...-gweb-fix-segfault-with-musl-v1.1.21.patch | 34 +++++++++++++++++++ > .../connman/connman_1.37.bb | 5 ++- > 2 files changed, 38 insertions(+), 1 deletion(-) > create mode 100644 > meta/recipes-connectivity/connman/connman/0003-gweb-fix-segfault-with-musl-v1.1.21.patch > > diff --git > a/meta/recipes-connectivity/connman/connman/0003-gweb-fix-segfault-with-musl-v1.1.21.patch > b/meta/recipes- > connectivity/connman/connman/0003-gweb-fix-segfault-with-musl-v1.1.21.patch > new file mode 100644 > index 0000000000..43b43bc9f8 > --- /dev/null > +++ > b/meta/recipes-connectivity/connman/connman/0003-gweb-fix-segfault-with-musl-v1.1.21.patch > @@ -0,0 +1,34 @@ > +From f0a8c69971b30ea7ca255bb885fdd1179fa5d298 Mon Sep 17 00:00:00 2001 > +From: Nicola Lunghi <[email protected]> > +Date: Thu, 23 May 2019 07:55:25 +0100 > +Subject: [PATCH] gweb: fix segfault with musl v1.1.21 > + > +In musl > 1.1.21 freeaddrinfo() implementation changed and > +was causing a segmentation fault on recent Yocto using musl. > + > +See this commit: > + > + > https://git.musl-libc.org/cgit/musl/commit/src/network/freeaddrinfo.c?id=d1395c43c019aec6b855cf3c656bf47c8a719e7f > + > +Upstream-Status: Submitted > +--- > + gweb/gweb.c | 3 ++- > + 1 file changed, 2 insertions(+), 1 deletion(-) > + > +diff --git a/gweb/gweb.c b/gweb/gweb.c > +index 393afe0a..12fcb1d8 100644 > +--- a/gweb/gweb.c > ++++ b/gweb/gweb.c > +@@ -1274,7 +1274,8 @@ static bool is_ip_address(const char *host) > + addr = NULL; > + > + result = getaddrinfo(host, NULL, &hints, &addr); > +- freeaddrinfo(addr); > ++ if(!result) > ++ freeaddrinfo(addr); > + > + return result == 0; > + } > +-- > +2.19.1 > + > diff --git a/meta/recipes-connectivity/connman/connman_1.37.bb > b/meta/recipes-connectivity/connman/connman_1.37.bb > index 2cf904cd85..f52b21cae3 100644 > --- a/meta/recipes-connectivity/connman/connman_1.37.bb > +++ b/meta/recipes-connectivity/connman/connman_1.37.bb > @@ -7,7 +7,10 @@ SRC_URI = > "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \ > file://no-version-scripts.patch \ > " > > -SRC_URI_append_libc-musl = " > file://0002-resolve-musl-does-not-implement-res_ninit.patch" > +SRC_URI_append_libc-musl = " \ > + file://0002-resolve-musl-does-not-implement-res_ninit.patch \ > + file://0003-gweb-fix-segfault-with-musl-v1.1.21.patch \ > +"
This fix is not musl specific. Cheers, Andre' > > SRC_URI[md5sum] = "75012084f14fb63a84b116e66c6e94fb" > SRC_URI[sha256sum] = > "6ce29b3eb0bb16a7387bc609c39455fd13064bdcde5a4d185fab3a0c71946e16" > -- > 2.19.1 > -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
