Do you have any feedback on this patch ? Thanks!
On Fri, 28 Jun 2019 at 12:14, Jean-Tiare Le Bigot < [email protected]> wrote: > From: Joël Esponde <[email protected]> > > populate_packages relies on ``mkdir`` to both create a directory and set > its permissions. However, ``mkdir`` honors the ``umask`` value. > Therefore, some bits may be lost in the operation. In our case, the > setgid bit on the directories were lost. > > This commit fixes this by having a distinct call to create the directory > and to set the permissions. > > Signed-off-by: Jean-Tiare Le Bigot <[email protected]> > --- > meta/classes/package.bbclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass > index 20d72bba79..cd223a121e 100644 > --- a/meta/classes/package.bbclass > +++ b/meta/classes/package.bbclass > @@ -1216,7 +1216,8 @@ python populate_packages () { > src = os.path.join(src, p) > dest = os.path.join(dest, p) > fstat = cpath.stat(src) > - os.mkdir(dest, fstat.st_mode) > + os.mkdir(dest) > + os.chmod(dest, fstat.st_mode) > os.chown(dest, fstat.st_uid, fstat.st_gid) > if p not in seen: > seen.append(p) > -- > 2.19.1 > > -- Jean-Tiare Le Bigot
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
