The configure script has already found IPT_LIB_DIR via pkgconfig, so the configure-cross.patch really just introduces dead and broken fallback code.
Broken, because the SYSROOT variable does not actually get set to a sensible value - the argument $1 passed to the configure script when invoked from the Makefile is KERNEL_INCLUDE, which we set to ${STAGING_INCDIR} in EXTRA_OEMAKE. Obviously that directory does not have /lib or /usr subdirectories, so we're not really helping the fallback logic in check_ipt_lib_dir() - in fact, we're more or less guaranteeing that we won't find those .so files. Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk> --- .../iproute2/iproute2/configure-cross.patch | 32 ------------------- .../iproute2/iproute2_4.19.0.bb | 1 - 2 files changed, 33 deletions(-) delete mode 100644 meta/recipes-connectivity/iproute2/iproute2/configure-cross.patch diff --git a/meta/recipes-connectivity/iproute2/iproute2/configure-cross.patch b/meta/recipes-connectivity/iproute2/iproute2/configure-cross.patch deleted file mode 100644 index 8b75a2ada4..0000000000 --- a/meta/recipes-connectivity/iproute2/iproute2/configure-cross.patch +++ /dev/null @@ -1,32 +0,0 @@ -From 85b0589b4843c03e8e6fd9416d71ea449a73c5c0 Mon Sep 17 00:00:00 2001 -From: Koen Kooi <k...@dominion.thruhere.net> -Date: Thu, 3 Nov 2011 10:46:16 +0100 -Subject: [PATCH] make configure cross compile safe - -According to Kevin Tian: -Upstream-Status: Pending - -Signed-off-by: Koen Kooi <k...@dominion.thruhere.net> -Signed-off-by: Shane Wang <shane.w...@intel.com> - -Index: iproute2-4.14.1/configure -=================================================================== ---- iproute2-4.14.1.orig/configure -+++ iproute2-4.14.1/configure -@@ -2,6 +2,7 @@ - # This is not an autoconf generated configure - # - INCLUDE=${1:-"$PWD/include"} -+SYSROOT=$1 - - # Output file which is input to Makefile - CONFIG=config.mk -@@ -195,7 +196,7 @@ check_ipt_lib_dir() - return - fi - -- for dir in /lib /usr/lib /usr/local/lib -+ for dir in $SYSROOT/lib $SYSROOT/usr/lib $SYSROOT/usr/local/lib - do - for file in $dir/{xtables,iptables}/lib*t_*so ; do - if [ -f $file ]; then diff --git a/meta/recipes-connectivity/iproute2/iproute2_4.19.0.bb b/meta/recipes-connectivity/iproute2/iproute2_4.19.0.bb index 6db4062d68..b1db40885a 100644 --- a/meta/recipes-connectivity/iproute2/iproute2_4.19.0.bb +++ b/meta/recipes-connectivity/iproute2/iproute2_4.19.0.bb @@ -1,7 +1,6 @@ require iproute2.inc SRC_URI = "${KERNELORG_MIRROR}/linux/utils/net/${BPN}/${BP}.tar.xz \ - file://configure-cross.patch \ file://0001-libc-compat.h-add-musl-workaround.patch \ file://0001-ip-Remove-unneed-header.patch \ " -- 2.20.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core