On 8/3/19 11:54 AM, Alexander Kanavin wrote:
On Sat, 3 Aug 2019 at 20:36, Khem Raj <[email protected] <mailto:[email protected]>> wrote:

    diff --git a/meta/recipes-devtools/llvm/llvm_git.bb
    <http://llvm_git.bb> b/meta/recipes-devtools/llvm/llvm_git.bb
    <http://llvm_git.bb>
    index 0067635c2b..35ad3ced37 100644
    --- a/meta/recipes-devtools/llvm/llvm_git.bb <http://llvm_git.bb>
    +++ b/meta/recipes-devtools/llvm/llvm_git.bb <http://llvm_git.bb>
    BRANCH = "release/${MAJOR_VERSION}.x"
     MAJOR_VERSION = "8"
     MINOR_VERSION = "0"
    -PATCH_VERSION = "0"
    +PATCH_VERSION = "1"
     SOLIBVER = "1"
     PV = "${MAJOR_VERSION}.${MINOR_VERSION}.${PATCH_VERSION}"
     SRC_URI =
    "git://github.com/llvm/llvm-project.git;branch=${BRANCH}
    <http://github.com/llvm/llvm-project.git;branch=$%7BBRANCH%7D> \
    "-Dgallium-xa=true, -Dgallium-xa=false"


Should this bit also use LLVMVERSION?  It would be good to define the llvm version in a single place, otherwise we will continue to trip over partial mismatching updates. MAJOR_VERSION can be easily determined via inline python.

it will limit the option of having another llvm recipe which could be provided by other layers for different reasons. so we provide a fallback implementation if someone wants to override they can.



Alex
-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to