On 8/14/19 10:53 AM, Bruce Ashfield wrote:


On Tue, Aug 13, 2019 at 9:59 PM Hongzhi, Song <hongzhi.s...@windriver.com <mailto:hongzhi.s...@windriver.com>> wrote:


    On 8/13/19 8:27 PM, Bruce Ashfield wrote:
    >
    >
    > On Tue, Aug 13, 2019 at 1:35 AM Hongzhi.Song
    > <hongzhi.s...@windriver.com <mailto:hongzhi.s...@windriver.com>
    <mailto:hongzhi.s...@windriver.com
    <mailto:hongzhi.s...@windriver.com>>> wrote:
    >
    >     A new patch let kernel source Documentation/Kconfig in top
    Kconfig
    >     So kernel-devsrc should include Documentation/ too.
    >     Otherwise "make scripts" will fails.
    >
    >     patch:
    >     commit b1663d7e3a7961fc45262fd68a89253f2803036c
    >     Author: Mauro Carvalho Chehab <mchehab+sams...@kernel.org
    <mailto:mchehab%2bsams...@kernel.org>
    >     <mailto:mchehab%2bsams...@kernel.org
    <mailto:mchehab%252bsams...@kernel.org>>>
    >     Date:   Tue Jun 4 09:26:27 2019 -0300
    >
    >         docs: Kbuild/Makefile: allow check for missing docs at
    build time
    >
    >         While this doesn't make sense for production Kernels, in
    order to
    >         avoid regressions when documents are touched, let's add a
    >         check target at the make file.
    >
    >         Signed-off-by: Mauro Carvalho Chehab
    >     <mchehab+sams...@kernel.org
    <mailto:mchehab%2bsams...@kernel.org>
    <mailto:mchehab%2bsams...@kernel.org
    <mailto:mchehab%252bsams...@kernel.org>>>
    >         Signed-off-by: Jonathan Corbet <cor...@lwn.net
    <mailto:cor...@lwn.net>
    >     <mailto:cor...@lwn.net <mailto:cor...@lwn.net>>>
    >
    >     Signed-off-by: Hongzhi.Song <hongzhi.s...@windriver.com
    <mailto:hongzhi.s...@windriver.com>
    >     <mailto:hongzhi.s...@windriver.com
    <mailto:hongzhi.s...@windriver.com>>>
    >     ---
    >      meta/recipes-kernel/linux/kernel-devsrc.bb
    <http://kernel-devsrc.bb>
    >     <http://kernel-devsrc.bb> | 2 +-
    >      1 file changed, 1 insertion(+), 1 deletion(-)
    >
    >     diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
    <http://kernel-devsrc.bb>
    >     <http://kernel-devsrc.bb>
    >     b/meta/recipes-kernel/linux/kernel-devsrc.bb
    <http://kernel-devsrc.bb> <http://kernel-devsrc.bb>
    >     index 5ec5929..a874e06 100644
    >     --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
    <http://kernel-devsrc.bb>
    >     <http://kernel-devsrc.bb>
    >     +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
    <http://kernel-devsrc.bb>
    >     <http://kernel-devsrc.bb>
    >     @@ -65,7 +65,7 @@ do_install() {
    >          )
    >
    >          # then drop all but the needed Makefiles/Kconfig files
    >     -    rm -rf $kerneldir/build/Documentation
    >     +    #rm -rf $kerneldir/build/Documentation
    >
    >
    > In the spirit of keeping kernel-devsrc as small as possible (I have
    > another patch pending if you really want the full kernel
    source), this
    > should only keep the Documentation/ files that are required to pass
    > the check, not keep all of Documentation.


    If you have a better patch, I am pleasure to accept it.


???

This is where you'd typically do a v2 of the patch after getting a review of a change.

But if you are refusing the feedback, then yes, I'll do a version of the patch myself rather than just blindly copying in all of the documentation. I'll submit it myself.

RP/Ross, whoever is taking in patches, drop this version, and I'll do my own.


I am not very familiar with the kernel-devsrc.bb. I have no objection for your decision.

Thanks,

--Hongzhi



Cheers,

Bruce


    Thanks,

    --Hongzhi


    > Bruce
    >
    >          rm -rf $kerneldir/build/scripts
    >          rm -rf $kerneldir/build/include
    >
    >     --
    >     2.8.1
    >
    >     --
    >     _______________________________________________
    >     Openembedded-core mailing list
    > Openembedded-core@lists.openembedded.org
    <mailto:Openembedded-core@lists.openembedded.org>
    >     <mailto:Openembedded-core@lists.openembedded.org
    <mailto:Openembedded-core@lists.openembedded.org>>
    > http://lists.openembedded.org/mailman/listinfo/openembedded-core
    >
    >
    >
    > --
    > - Thou shalt not follow the NULL pointer, for chaos and madness
    await
    > thee at its end
    > - "Use the force Harry" - Gandalf, Star Trek II
    >



--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to