On 11/30/2011 02:31 PM, Khem Raj wrote: > On Wed, Nov 30, 2011 at 1:49 PM, Darren Hart <[email protected]> wrote: >> From: Darren Hart <[email protected]> >> >> If the configure script isn't found, report the explicit path tried. >> This can help debug subtle errors where the ${S} sourcedir may not >> be exactly what is expected. >> >> Signed-off-by: Darren Hart <[email protected]> >> --- >> meta/classes/autotools.bbclass | 9 +++++---- >> 1 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass >> index 37e7d4b..7536bac 100644 >> --- a/meta/classes/autotools.bbclass >> +++ b/meta/classes/autotools.bbclass >> @@ -70,11 +70,12 @@ CONFIGUREOPT_DEPTRACK = "--disable-dependency-tracking" >> >> >> oe_runconf () { >> - if [ -x ${S}/configure ] ; then >> - bbnote "Running ${S}/configure ${CONFIGUREOPTS} >> ${EXTRA_OECONF} $@" >> - ${S}/configure ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@" || >> bbfatal "oe_runconf failed" >> + cfgscript="${S}/configure" >> + if [ -x "$cfgscript" ] ; then >> + bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} >> $@" >> + $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@" || bbfatal >> "oe_runconf failed" >> else >> - bbfatal "no configure script found" >> + bbfatal "no configure script found at $cfgscript" > > why not just do one line change something like > > bbfatal "configure script ${S}/configure not found"
I prefer to use a variable when I need a value more than once. It avoids future bugs where one is changed and the others were missed. As this string is used 4 times, it seemed like the right call. -- Darren > >> fi >> } >> >> -- >> 1.7.6.4 >> >> >> _______________________________________________ >> Openembedded-core mailing list >> [email protected] >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
