Paul, Thanks for your feedback. I will try to incorporate your feedback in the commit.
Thanks, Nitin > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of > Paul Menzel > Sent: Saturday, December 03, 2011 10:08 AM > To: [email protected] > Subject: Re: [OE-core] [PATCH 02/11] mdadm: fix CC definition in the > Makefile > > Dear Nitin, > > > thank you for your patch. > > Am Freitag, den 02.12.2011, 12:20 -0800 schrieb > [email protected]: > > From: Nitin A Kamble <[email protected]> > > > > By hardcoding CC's definition in the Makefile, all the gcc parameters > > set by tune settings are lost. Causing compile failure with x32 > > toolchain > > > > As the bitbake defined CC is good, there is no need to redfine CC in > > the > > red*e*fine > > > make file, hence removed it to fix the issue. > > > > This fixes bug: [YOCTO #1414] > > > > Signed-off-by: Nitin A Kamble <[email protected]> > > --- > > .../mdadm/files/mdadm_fix_for_x32.patch | 24 > ++++++++++++++++++++ > > meta/recipes-extended/mdadm/mdadm_3.2.2.bb | 3 +- > > 2 files changed, 26 insertions(+), 1 deletions(-) create mode > 100644 > > meta/recipes-extended/mdadm/files/mdadm_fix_for_x32.patch > > > > diff --git a/meta/recipes- > extended/mdadm/files/mdadm_fix_for_x32.patch > > b/meta/recipes-extended/mdadm/files/mdadm_fix_for_x32.patch > > new file mode 100644 > > index 0000000..898e70b > > --- /dev/null > > +++ b/meta/recipes-extended/mdadm/files/mdadm_fix_for_x32.patch > > @@ -0,0 +1,24 @@ > > +UpstreamStatus: pending > > + > > +By hardcoding CC's definition in the Makefile, all the gcc > parameters > > +set by tune settings are lost. Causing compile failure with x32 > > +toolchain > > + > > +As the bitbake defined CC is good, there is no need to redfine CC in > > +the make file, hence removed it to fix the issue. > > + > > +Signed-Off-By: Nitin A Kamble <[email protected]> > > +2011/12/01 > > + > > +Index: mdadm-3.2.2/Makefile > > +=================================================================== > > +--- mdadm-3.2.2.orig/Makefile > > ++++ mdadm-3.2.2/Makefile > > +@@ -40,7 +40,7 @@ KLIBC=/home/src/klibc/klibc-0.77 > > + > > + KLIBC_GCC = gcc -nostdinc -iwithprefix include > > + -I$(KLIBC)/klibc/include -I$(KLIBC)/linux/include > > + -I$(KLIBC)/klibc/arch/i386/include -I$(KLIBC)/klibc/include/bits32 > > + > > +-CC = $(CROSS_COMPILE)gcc > > ++#CC = $(CROSS_COMPILE)gcc > > I would prefer to fix this the way it can be applied upstream. I could > even ask them to apply it. > > > + CXFLAGS = -ggdb > > + CWFLAGS = -Wall -Werror -Wstrict-prototypes -Wextra > > + -Wno-unused-parameter ifdef WARN_UNUSED > > […] > > > Thanks, > > Paul _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
