On Mon, 2019-12-30 at 14:10 -0800, Khem Raj wrote:
> On Mon, Dec 30, 2019 at 12:48 AM Richard Purdie
> <richard.pur...@linuxfoundation.org> wrote:
> > As pointed out by Masahiro Yamada <masahi...@kernel.org>, ('' or
> > 'custom')
> > equates to "custom" and this code seems unecesaarily complicated
> > and unused.
> >
> > It was likely intended to supress the value if XXX_OS was set to ''
> > but the
> > code doesn't actually do that. Simplify it as we shouldn't have
> > this indirection
> > if we don't need it, its horrible.
> >
>
> introduced here in oe classic
> https://git.openembedded.org/openembedded/commit/?id=e485a5d542a24109c8ab97e58916359efc0cd044
>
> and fixed here
> https://git.openembedded.org/openembedded/commit/?id=ff02b94de71
>
> downstreamed into poky
> https://git.openembedded.org/openembedded-core/commit/?id=5ad6d9a94a0
>
> I think oe-core missed the second commit. perhaps it seems that it
> was created out of poky lineage rather than oe classic.
>
> maybe porting the second commit above would be better option here.
Maybe, except that nobody has complained in 8 years. The expression is
horrible so I'd prefer to drop it if we don't need it. If needed
someone can override the variable anyway...
Cheers,
Richard
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
