On 2020-02-10 8:01 a.m., Khem Raj wrote:
On Mon, Feb 10, 2020 at 3:42 AM Alexander Kanavin
<[email protected]> wrote:
As long as we're consistent, I'm ok with either option. I think it's ultimately
up to RP to make the call.
The usecase is fine, as long as we add x265 support to gst plugins and
ffmeg and it gets tested via reference
images, I see no issues adding it.
I'm changing my opinion now and leaning toward meta-multimedia as Khem
originally suggested.
For the simple reason that I think x265 only builds (easily) for x86
based platforms.
That being the case:
we only add the packageconfig option to ffmpeg but don't enable by
default in the PACKAGECONFIG default in the ffmpeg recipe.
PACKAGECONFIG[x265] = "--enable-libx265,--disable-libx265,x265"
And add the x265 recipe to meta-multimedia and limit to x86 at this time.
Is this what I would set in the x265 recipe?
COMPATIBLE_MACHINE_x86 = "(.*)"
COMPATIBLE_MACHINE_x86-64 = "(.*)"
Alex
On Mon, 10 Feb 2020 at 07:16, Scott Branden via Openembedded-core
<[email protected]> wrote:
On 2020-02-09 3:35 p.m., Khem Raj wrote:
On Sun, Feb 9, 2020 at 11:27 AM Scott Branden
<[email protected]> wrote:
On 2020-02-08 11:18 a.m., Khem Raj wrote:
On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <[email protected]> wrote:
Hi Khem,
On 2020-02-07 5:12 p.m., Khem Raj wrote:
On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core
<[email protected]> wrote:
Add x265 recipe from latest revision of stable branch.
I wonder if it belongs to core are there deps on it that we need in common
metadata
I simply followed where x264 recipe is located and placed x265 beside it.
Both are needed when enabled in ffmpeg.
I don't know if that answers your question as to where they should be located.
idea is to keep small and therefore we should assess the inclusions in core
we have many packageconfigs which require packages from other layers
so if ffmpeg needs it and is optional then it should be fine to keep
it in meta-multimedia and packageconfig in ffmpeg disabled by default.
I don't see why x264 would be in core and x265 in meta-multimedia.
Both should be moved to meta-multimedia then?
I followed the thread a bit and I see there are followups where
usecase for other recipes in core is now
established, where this seemed a leaf package being added to oe-core,
So perhaps it should be added
to validation loops as well like x264.
I leave it to the powers that be to decide where to place this recipe.
I think you would also require a bbappend to fffmpeg recipe to add x264
and x265 to ffmpeg packageconfig.
if that is the case, why not move ffmpeg to meta-multimedia as well?
You would not go down that line of thought since these packages are in
the dependency chain for validating reference
images in core along with they being used by other packages from other layers.
Signed-off-by: Scott Branden <[email protected]>
---
meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
diff --git a/meta/recipes-multimedia/x265/x265_git.bb
b/meta/recipes-multimedia/x265/x265_git.bb
new file mode 100644
index 0000000000..796fbbc13a
--- /dev/null
+++ b/meta/recipes-multimedia/x265/x265_git.bb
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams
into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html";
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+ "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--
2.17.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
