On Wed, 2020-02-19 at 22:26 +0000, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: [email protected] < > > [email protected]> On Behalf Of > > Richard Purdie > > Sent: den 19 februari 2020 19:38 > > To: [email protected] > > Subject: [OE-core] [PATCH 3/3] oeqa/selftest: Drop 'backup' code > > and SIGTERM handler > > > > Now selftest is using its own copied build directory, we can stop > > worrying about > > copying files around as backup, and drop the SIGTERM handler to try > > and restore > > them, simplifying the code. > > > > Signed-off-by: Richard Purdie <[email protected]> > > --- > > meta/lib/oeqa/selftest/case.py | 30 +------------------- > > meta/lib/oeqa/selftest/context.py | 47 ++------------------------- > > ---- > > 2 files changed, 4 insertions(+), 73 deletions(-) > > [cut] > > > @@ -329,18 +311,9 @@ class > > OESelftestTestContextExecutor(OETestContextExecutor): > > > > return rc > > > > - def _signal_clean_handler(self, signum, frame): > > - if self.ourpid == os.getpid(): > > - sys.exit(1) > > - > > def run(self, logger, args): > > self._process_args(logger, args) > > > > - # Setup a SIGTERM handler to allow restoration of files > > like local.conf and bblayers.conf > > - # but don't interfer with other processes > > - self.ourpid = os.getpid() > > - signal.signal(signal.SIGTERM, self._signal_clean_handler) > > - > > What's the point of the first patch in this series, when you just > remove it all again here in the third patch?
The bug affects stable series builds as well as master. We're probably unlikely to accept 2/3 or 3/3 into stable builds? I therefore wrote it as a series, just in case the stable maintainers do pick up 1/3 which I'd figured out before writing 2/3 and 3/3. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
