On 3/3/20 11:10 PM, Martin Jansa wrote:
On Tue, Mar 03, 2020 at 09:45:25PM +0000, Richard Purdie wrote:
On Tue, 2020-03-03 at 22:23 +0100, Leon Woestenberg wrote:
Hello all,

On Tue, Mar 3, 2020 at 6:42 PM Jacob Kroon <[email protected]>
wrote:
On 3/1/20 12:47 AM, Matt Ranostay wrote:
Add pixmap to PACKAGECONFIG defaults to allow consumers to
render color emojis without distro changes.

Signed-off-by: Matt Ranostay <[email protected]>
---
-PACKAGECONFIG ??= "zlib"
+PACKAGECONFIG ??= "zlib pixmap"

Wouldn't it make sense to keep it off by default and let whoever
needs it enable it ?
/Jacob

I would agree, and would also vote for opt-in rather than opt-out for
this use-case.

Do we have a more generic stance on how we select the PACKAGECONFIG
defaults?

It feels like I've seen this come in a few times, I've said no, it
keeps coming back, I gave in.

Basically the policy is trying to keep things as sensible defaults for
the majority of users. Many of our users are concerned about build
time, space usage and minimisation of dependencies.

These things do change over time as our userbase changes and as the
demands and expectations from software changes.

In this case its fairly hard to figure out that tweaking this option
breaks emojis and libpng isn't such an uncommon or problematic library.

Its hard for me as the maintainer of all this to get a decent feeling
for how people feel about some changes so its also based a lot on feel,
there is only limited patch review a lot of the time.

If there is strong demand not to have this, we can revert it. I'd like
to see how many people do/don't want it and see a few more opinions on
that though.

We (as LGE) have pixmap enabled at least since 2015, because people
really want their color emojis on TVs, so having this enabled by default
will allow me to eventually drop 1 bbappend from our layers eventually
when we upgrade to 3.1.

So I would vote to keep this change.

But on the other hand it will still leave 828 other bbappends, so it
doesn't make much difference to me :).


Fair enough, sounds like there are good reasons to have it enabled by default.

/Jacob
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to