On Tue, Mar 31, 2020 at 3:47 PM Denys Dmytriyenko <[email protected]> wrote: > On Tue, Mar 31, 2020 at 03:18:41PM -0300, Otavio Salvador wrote: > > On Tue, Mar 31, 2020 at 3:07 PM Denys Dmytriyenko <[email protected]> wrote: > > > On Tue, Mar 31, 2020 at 02:46:41PM -0300, Otavio Salvador wrote: > > > > Add the Git revision used for the build. It is very useful especially > > > > when > > > > using custom or vendor U-Boot forks so we can map a binary to a specific > > > > source revision. Valid values are "0" or "1". > > > > > > Well, UBOOT_LOCALVERSION was originally added specifically for this > > > purpose - > > > to be able to append git hash. > > > > Not really; it kinda of maps to what Linux kernel provides and it is a > > "suffix" for the version. For example "-ti" to imply it came from a > > Texas Instruments fork. > > There are multiple uses and you can append anything you want. Here's the > original patch that specifically mentions adding git hash, as an example: > https://lists.openembedded.org/g/openembedded-core/topic/72204283 > > > > > This is based on a class which has been in use in `meta-freescale` BSP > > > > for years and has been very useful especially for custom U-Boot releases > > > > as it allow we to know the exact Git revision used for the binary. > > > > > > And in meta-ti BSP we've used for many years: > > > UBOOT_LOCALVERSION = "-g${@get_git_revision('${S}')}" > > > > > > And get_git_revision() just calls "git rev-parse HEAD" > > > > > > So, it seems a bit redundant to add another variable for this... > > > > How I use this is: > > > > UBOOT_LOCALVERSION = "-updatehub" > > UBOOT_LOCALVERSION_AUTO = "1" > > > > I think it is way easier for users to do that. Using inline Python > > code is possible but it is not something I qualify as user friendly. > > UBOOT_LOCALVERSION = "-updatehub-g${SRCPV}"
U-Boot 2020.01-updatehub-AUTOINC+d228123da8 (Mar 20 2020 - 17:05:55 +0000) This is kinda ugly. Also the old behaviour is still supported. Let's see what others from community think about it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#136894): https://lists.openembedded.org/g/openembedded-core/message/136894 Mute This Topic: https://lists.openembedded.org/mt/72682446/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
