On Sat, 4 Apr 2020, Richard Purdie wrote: > On Sat, 2020-04-04 at 09:01 -0400, Robert P. J. Day wrote: > > On Sat, 4 Apr 2020, Richard Purdie wrote: > > > > > On Sat, 2020-04-04 at 08:00 -0400, [email protected] wrote: > > > > Clarify the setting of "S" so there is absolutely no confusion. > > > > > > > > Signed-off-by: Robert P. J. Day <[email protected]> > > > > > > > > --- > > > > > > > > diff --git a/meta/classes/bin_package.bbclass > > > > b/meta/classes/bin_package.bbclass > > > > index cbc9b1fa13..4e74557967 100644 > > > > --- a/meta/classes/bin_package.bbclass > > > > +++ b/meta/classes/bin_package.bbclass > > > > @@ -14,8 +14,8 @@ > > > > # > > > > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0"; > > > > # > > > > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, > > > > otherwise > > > > -# they would be in ${WORKDIR}. > > > > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, > > > > otherwise > > > > +# they would be in S=${WORKDIR}. > > > > # > > > > > > I strongly disagree actually. Setting subdir in SRC_URI does not > > > change > > > the value of S. What happens is what the comment says, its unpacked > > > to > > > ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at > > > whatever > > > its set to. > > > > so if one inherits bin_package and uses a "subdir" option, what is > > installed (via tar) is the entire subdir directory structure, as in > > > > foo-1.0/* > > That sounds more confusing. > > The source component of SRC_URI that has subdir set against it is > extracted to ${WORKDIR}/<subdir> rather than ${WORKDIR}/. Nothing more, > nothing less. > > > unless the recipe explicitly sets S to match it, is that it? that > > might be worth noting in the comments, then. > > S has nothing to do with this so stop trying to include it.
i actually think we're agreeing here, i'm just explaining myself badly. i'll try again later. rday
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#137017): https://lists.openembedded.org/g/openembedded-core/message/137017 Mute This Topic: https://lists.openembedded.org/mt/72768535/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
