Thanks for the suggestion. I'll send out V2.

Regards,
Chen Qi
________________________________
From: Richard Purdie <[email protected]>
Sent: Thursday, April 23, 2020 7:19
To: Chen, Qi <[email protected]>; [email protected] 
<[email protected]>
Subject: Re: [OE-core][PATCH 1/2] toolchain-shar-extract.sh: remove legacy .o 
files

On Wed, 2020-04-22 at 15:28 +0800, Chen Qi wrote:
> We want to make sure `make scripts prepare` succeed inside SDK. However,
> the legacy .o files under scripts/kconfig will introduce build error
> on some hosts, thus removing them.
>
> Signed-off-by: Chen Qi <[email protected]>
> ---
>  meta/files/toolchain-shar-extract.sh | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/files/toolchain-shar-extract.sh 
> b/meta/files/toolchain-shar-extract.sh
> index 04527f891f..61911e72c9 100644
> --- a/meta/files/toolchain-shar-extract.sh
> +++ b/meta/files/toolchain-shar-extract.sh
> @@ -286,6 +286,9 @@ if [ -e "$post_relocate" ]; then
>        $SUDO_EXEC rm -f $post_relocate
>  fi
>
> +# Remove legacy .o files to avoid kernel build failure
> +rm -f $target_sdk_dir/sysroots/*/usr/src/kernel/scripts/kconfig/*.o
> +

We should be removing these at SDK construction time, not at extraction
time, then the SDK is smaller and we don't have special cases in this
extraction script...

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#137399): 
https://lists.openembedded.org/g/openembedded-core/message/137399
Mute This Topic: https://lists.openembedded.org/mt/73190691/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to