On Thu, May 7, 2020 at 4:02 PM Steve Sakoman <[email protected]> wrote: > > On Thu, May 7, 2020 at 10:30 AM Denys Dmytriyenko <[email protected]> wrote: > > > > On Thu, May 07, 2020 at 01:20:40PM -0700, Khem Raj wrote: > > > > > > > > > On 5/7/20 12:57 PM, Denys Dmytriyenko wrote: > > > > On Thu, May 07, 2020 at 12:44:15PM -0700, Khem Raj wrote: > > > >> > > > >> > > > >> On 5/3/20 3:51 PM, Steve Sakoman wrote: > > > >>> Should I consider these two patches for dunfell LTS? > > > >>> > > > >> > > > >> Yes I think they are fixing a problem and are safe. > > > > > > > > I don't think it is safe though! > > > > > > > > The code has been moved to create_sdk_files() which is a POSTPROCESS > > > > command > > > > for SDK creation. What if SDK already provides own /etc/ld.so.conf? The > > > > code > > > > just simply overwrites it. > > > > > > > > > > but are there such usecases ? looking closely if SDK is extending the > > > ld.so.conf then they should be appending to it instead of overwriting > > > and same is true for this patch for master. > > > > Exactly my point - should probably append, not overwrite. > > As of usecases - I can think of a non-standard nativesdk tool that adjusts > > /etc/ld.so.conf during install... > > I think you've convinced me to pass on this for dunfell (at least in > the short term) > > If a patch is submitted that appends rather than overwrites I'll > consider the series again once it makes it into master. >
yes, I think that will be right thing to do although I think it fills in a good gap in dunfell but as it is might not work as expected. > If you submit such a patch please tag it with [dunfell] too. > > Thanks for the comments! > > Steve > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138041): https://lists.openembedded.org/g/openembedded-core/message/138041 Mute This Topic: https://lists.openembedded.org/mt/73326300/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
