On Sun, May 10, 2020 at 11:41 AM Denys Dmytriyenko <[email protected]> wrote:

> On Sat, May 09, 2020 at 02:29:09PM -0700, Tim Orling wrote:
> > This is a candidate for backport to stable once it lands in master.
>
> How so?
>

It fixes a bug in upgrade check. For users that are on stable releases, who
might be maintaining their own python packages, they will be affected by
this.


>
> > On Sat, May 9, 2020 at 2:12 PM Tim Orling via lists.openembedded.org
> > <[email protected]> wrote:
> >
> > > This version looks good.
> > >
> > > On Sat, May 9, 2020 at 1:33 PM Konrad Weihmann <[email protected]>
> > > wrote:
> > >
> > >> Some pypi packages do have suffixes like dev, or a0 or b1.
> > >> When doing a version check on these, the version will get falsely
> > >> identified as major release versions.
> > >> Add a terminating slash to rule out those false positives
> > >>
> > >> Changes v2:
> > >>
> > >> - ignore suffix versions instead of reporting them
> > >>
> > >> Signed-off-by: Konrad Weihmann <[email protected]>
> > >>
> > >
> > > Reviewed-by: Tim Orling <[email protected]>
> > >
> > > ---
> > >>  meta/classes/pypi.bbclass | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass
> > >> index e5d7ab3ce1..ffa8aa3ff4 100644
> > >> --- a/meta/classes/pypi.bbclass
> > >> +++ b/meta/classes/pypi.bbclass
> > >> @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}"
> > >>  S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}"
> > >>
> > >>  UPSTREAM_CHECK_URI ?= "https://pypi.python.org/pypi/${PYPI_PACKAGE}/
> "
> > >> -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)"
> > >> +UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)/"
> > >> --
> > >> 2.20.1
> > >>
> > >>
> > >>
> > >
>
> > 
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#138100): 
https://lists.openembedded.org/g/openembedded-core/message/138100
Mute This Topic: https://lists.openembedded.org/mt/74103599/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to