On 6/9/20 5:44 PM, Richard Purdie wrote:
On Tue, 2020-06-09 at 16:11 +0200, Jacob Kroon wrote:
Signed-off-by: Jacob Kroon <jacob.kr...@gmail.com>
---
meta/classes/features_check.bbclass | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/meta/classes/features_check.bbclass
b/meta/classes/features_check.bbclass
index 4ba827d4ab..31ce600374 100644
--- a/meta/classes/features_check.bbclass
+++ b/meta/classes/features_check.bbclass
@@ -12,11 +12,25 @@
# Copyright 2019 (C) Texas Instruments Inc.
# Copyright 2013 (C) O.S. Systems Software LTDA.
+FEATURES_CHECK_INCLUDE_STACK := "${BBINCLUDESTACK}"
This looks like a rather heavy hit to want to take on every recipe
being parsed everywhere (I also really don't like seeing := needing to
be used).
Maybe I misunderstood you, but the check is only done in recipes that
inherit the class. If you are referring to the accompanied change in
BitBake for keeping track of the include stack, yeah that might be worse.
The direct assignment is needed in order to suppress false positives,
for instance when an .inc/.bbclass contains the inherit directive. Not
sure how to work around that without this.
I'd much rather this were some kind of test we could run periodically,
maybe on the infrastructure rather than the hit being taken all the
time.
Could we add something which just ran these tests? Maybe a class which
the autobuilder could inherit to enable these kinds of tests?
Maybe that is a better approach. autobuilder could send a summary report
periodically to the ml so that the warnings would be visible.
Jacob
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#139375):
https://lists.openembedded.org/g/openembedded-core/message/139375
Mute This Topic: https://lists.openembedded.org/mt/74774873/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
