Yes, as to lcl_maybe_fortify() being visible, but why the "?=" ? Maybe, the security flags Should have a pn-vim entry. I don't like that. Maybe the vim recipe should modify lcl_maybe_fortify() but I really don't like that either. Still, vim should be useable. What I do not understand is why this has not been reported. Is everybody using the vi provided by busybox?
Joe -----Original Message----- From: Andre McCurdy <[email protected]> Sent: Tuesday, June 9, 2020 3:59 PM To: Slater, Joseph <[email protected]> Cc: OE Core mailing list <[email protected]>; MacLeod, Randy <[email protected]> Subject: Re: [V2][oe-core][PATCH 1/1] vim: _FORTIFY_SOURCE=2 be gone On Tue, Jun 9, 2020 at 3:46 PM Joe Slater <[email protected]> wrote: > > vim will abort in many places with this setting. Replace it with the > benign _FORTIFY_SOURCE=1. > > Signed-off-by: Joe Slater <[email protected]> > --- > meta/recipes-support/vim/vim_8.2.bb | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta/recipes-support/vim/vim_8.2.bb > b/meta/recipes-support/vim/vim_8.2.bb > index 60946a181f..709b6ddb55 100644 > --- a/meta/recipes-support/vim/vim_8.2.bb > +++ b/meta/recipes-support/vim/vim_8.2.bb > @@ -8,3 +8,8 @@ BBCLASSEXTEND = "native" > ALTERNATIVE_${PN}_append = " xxd" > ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd" > ALTERNATIVE_LINK_NAME[xxd] = "${bindir}/xxd" > + > +# We override the default in security_flags.inc because vim (not > +vim-tiny!) will abort # in many places for _FORTIFY_SOURCE=2. Security > flags become part of CC. > +# > +lcl_maybe_fortify = > "${@oe.utils.conditional('DEBUG_BUILD','1','','-D_FORTIFY_SOURCE=1',d)}" "lcl_maybe_fortify" was supposed to be a private local variable in security_flags.inc. If it's now a documented global variable which recipes are allowed to mess with, it should be renamed (e.g. capitalised and the lcl_ prefix removed).
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139384): https://lists.openembedded.org/g/openembedded-core/message/139384 Mute This Topic: https://lists.openembedded.org/mt/74785809/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
