On Fri, Jun 12, 2020 at 2:38 PM Alex Kiernan via lists.openembedded.org <[email protected]> wrote: > > If there are multiple appends, ensure we concatenate compatible things: > > Traceback (most recent call last): > File "/home/akiernan/poky/scripts/recipetool", line 111, in <module> > ret = main() > File "/home/akiernan/poky/scripts/recipetool", line 100, in main > ret = args.func(args) > File "/home/akiernan/poky/scripts/lib/recipetool/edit.py", line 38, in edit > return scriptutils.run_editor([recipe_path] + appends, logger) > TypeError: can only concatenate list (not "tuple") to list > > Signed-off-by: Alex Kiernan <[email protected]> > --- >
I should add a test to this too, since what's there is well tested today (apart from edit!) > scripts/lib/recipetool/edit.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/lib/recipetool/edit.py b/scripts/lib/recipetool/edit.py > index 94bdf7bca4eb..d5b980a1c03e 100644 > --- a/scripts/lib/recipetool/edit.py > +++ b/scripts/lib/recipetool/edit.py > @@ -34,7 +34,7 @@ def edit(args): > recipe_path = tinfoil.get_recipe_file(args.target) > appends = tinfoil.get_file_appends(recipe_path) > > - return scriptutils.run_editor([recipe_path] + appends, logger) > + return scriptutils.run_editor([recipe_path] + list(appends), logger) > > > def register_commands(subparsers): > -- > 2.17.1 > > -- Alex Kiernan
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139442): https://lists.openembedded.org/g/openembedded-core/message/139442 Mute This Topic: https://lists.openembedded.org/mt/74839020/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
