On Thu, Jun 18, 2020 at 1:27 AM Jacob Kroon <[email protected]> wrote: > > On 6/18/20 1:12 AM, Richard Purdie wrote: > > On Wed, 2020-06-17 at 16:07 -0700, Christopher Clark wrote: > >> Both grub-native and grub-efi-native included packaging for the > >> grub-mkimage and grub-editenv tools, which prevented concurrent > >> installation of both the grub-native and grub-efi-native packages. > >> This caused errors on image generation with wic when populating > >> partitions with both legacy and efi boot support, so resolve this by > >> removing the duplicated tools from grub-efi-native and add a > >> runtime dependency from it to grub-native.> >> > > > > I think we want to PROVIDES_append_class-native = " grub-efi-native" in > > grub and then drop the BBCLASSEXTEND from grub-efi? > > Just for the record, I tested building grub-native (x86-64) both with > platform "pc" and "efi", and in the same build directory, and all tools > in ${bindir} were binary identical. Asking in #grub on freenode also > confirmed this, apparently Debian packaging also assumes this. > > So no grub-efi-native required, and we can remove that > _class_target/_class_native special handling as well.
I'm not as confident as I was about the results of the binary comparison that I did, since objdump definitely wasn't showing the strings differences that were clearly present between those binaries. I think that proposing this change was a mistake since there could well be other layers that depend on core having separate packages with behaviour specific to those that is needed. Sorry for the noise. Christopher
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139673): https://lists.openembedded.org/g/openembedded-core/message/139673 Mute This Topic: https://lists.openembedded.org/mt/74948517/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
