On Mon, Jun 22, 2020 at 11:06:53PM +0100, Richard Purdie wrote:
> On Mon, 2020-06-22 at 15:50 +0200, Torben Hohn wrote:
> > To use pkcs11, it is necessary to pass "-N pkcs11".
> > And there are also a few more options, that are useful.
> > 
> > Pass UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage, when signing the
> > fitImage.
> > 
> > Signed-off-by: Torben Hohn <[email protected]>
> > ---
> >  meta/classes/kernel-fitimage.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/classes/kernel-fitimage.bbclass
> > b/meta/classes/kernel-fitimage.bbclass
> > index 72b05ff8d1..afb62f1071 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -474,6 +474,7 @@ fitimage_assemble() {
> >                     ${@'-D "${UBOOT_MKIMAGE_DTCOPTS}"' if
> > len('${UBOOT_MKIMAGE_DTCOPTS}') else ''} \
> >                     -F -k "${UBOOT_SIGN_KEYDIR}" \
> >                     $add_key_to_u_boot \
> > +                        ${UBOOT_SIGN_EXTRA_OPTS} \
> >                     -r arch/${ARCH}/boot/${2}
> >     fi
> >  }
> 
> Does this new option need documenting in the class headers? or at least
> somewhere? I don't think it currently exists?

Yes. its new.

> 
> At the very least there should be a ??= assignment to "" as a default
> somewhere?

Shall i put that in meta/classes/uboot-sign.bbclass ?


> 
> Cheers,
> 
> Richard
> 

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#139814): 
https://lists.openembedded.org/g/openembedded-core/message/139814
Mute This Topic: https://lists.openembedded.org/mt/75038549/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to