Thanks for the fast reply!
Good catch, but we should still be masking in the permissions bits, we
just shouldn't be overwriting the non-permissions bits, I think?
The OP_CREATE/REPLACE/SET_XATTR operations in pseudo_op() don't use
msg_header.mode at all, it is only used for DB sanity checks, which in
turn only use the non-permission bits.
So it certainly does not hurt to add them back in, and thus might be the
proper thing to do.
Not knowing the code base I simply was being conservative and left the
original mode unaltered.
I can send an updated patch on Monday.
On a different note, the shared_setxattr() code for the darwin port is
very similar and also overwrites buf.st_mode and thus is also affected
by this buf. In addition to that it is also missing the changes
introduced by this commit
http://git.yoctoproject.org/cgit/cgit.cgi/pseudo/commit/?id=cc6b2008646318c01153d39fef191da3e35a5fc8,
since I don't have access to a darwin system to test any changes I left
the port alone, but someone should look into this.
--
Johannes Beisswenger
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#140017):
https://lists.openembedded.org/g/openembedded-core/message/140017
Mute This Topic: https://lists.openembedded.org/mt/75120999/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
