Hi Richard:
If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled
in gstreamer, that will cause the build break.
The root cause is the vulkan didn't support directfb.
So I remove this vulkan if directfb enabled.
Another solution is separate the directfb with directfb. Like below:
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \
Chenxi
On 2020/6/28 下午3:54, Richard Purdie wrote:
> On Sun, 2020-06-28 at 13:39 +0800, Chenxi Mao wrote:
>> vulkan didn't support directfb at all.
>> So remove this configuration if directfb enabled.
>>
>> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
>> Signed-off-by: Chenxi Mao <[email protected]>
>> ---
>> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> index 7a227fed51..aee001e641 100644
>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> @@ -24,7 +24,7 @@ inherit gobject-introspection
>> PACKAGECONFIG ??= " \
>> ${GSTREAMER_ORC} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
>> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
>> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
>> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
> This doesn't look right since what if DISTRO_FEATURES contains just
> vulkan? This patch would stop vulkan being enabled when directfb isn't
> enabled if I read it correctly?
>
> Cheers,
>
> Richard
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#140056):
https://lists.openembedded.org/g/openembedded-core/message/140056
Mute This Topic: https://lists.openembedded.org/mt/75166138/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
