On Fri, 2020-07-03 at 22:51 -0400, Bruce Ashfield wrote: > On Wed, Jul 1, 2020 at 11:22 AM Bruce Ashfield via > lists.openembedded.org > <[email protected]> wrote: > > On Wed, Jul 1, 2020 at 10:58 AM Andrey Zhizhikin < > > [email protected]> wrote: > > > Fetcher provides full paths to defconfig and scc files, which awk > > > comparison operator does not catch during construction of > > > src_uri_defconfig and sccs_from_src_uri lists. This causes the > > > src_uri_defconfig variable to come out empty, and fails further > > > validation if defconfig is only supplied via SRC_URI. > > > > > > Replace comparison operator with awk match function which > > > searches for > > > sub-string during filtering, effectively placing defconfig from > > > SRC_URI > > > into src_uri_defconfig and scc files in sccs_from_src_uri > > > respectively. > > > > > > Fixes: 23dcff0d396c (kernel/yocto: ensure that defconfigs are > > > processed first) > > > > v2 passes my testing as well. The autobuilder gets the final say, > > but > > I can't see this causing any issues. > > > > Richard, > > I didn't see this on master-next, and we got a different patch for > this on the list .. this is the preferred fix for readabilty. > > I just wanted to make sure you weren't waiting for me to send it in > my > next pull request. I can absolutely do that if you want.
I was waiting for some indication on your thoughts, I'll queue it :) Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140308): https://lists.openembedded.org/g/openembedded-core/message/140308 Mute This Topic: https://lists.openembedded.org/mt/75237251/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
