Hi Khem / Bjarne On Tuesday, 7 July 2020 07:50:47 NZST Khem Raj wrote: > On 7/6/20 12:42 PM, Bjarne Michelsen wrote: > > [Bug 13971] https://bugzilla.yoctoproject.org/show_bug.cgi?id=13971 > > > > A recipe using LICENSE=CLOSED would normally not have LIC_FILES_CHKSUM > > set. > > If LIC_FILES_CHKSUM was not set, it would cause `devtool upgrade` to fail. > > > > This fixes the issue by defaulting to an empty string if > > LIC_FILES_CHKSUM is not found. > > would it do just for recipes which use CLOSED for license ? > since we are synthesizing the checksum, It would be good to remain > prudent and not empty it out in general when non existent, perhaps > a warning for user to fix it in such cases would be appropriate
It would be nice to show an error if LIC_FILES_CHKSUM is empty and LICENSE != "CLOSED", although one would imagine this would be a fairly rare situation given that LIC_FILES_CHKSUM is mandated by the build system in that case and devtool upgrade requires a recipe to already exist (presumably one that has been built before). The fix itself is reasonable but the bug reference should be in the following form: Fixes: [YOCTO #13971]. Thanks Paul
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140371): https://lists.openembedded.org/g/openembedded-core/message/140371 Mute This Topic: https://lists.openembedded.org/mt/75341279/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
